mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hDCnB32JYz6n5Mr for ; Mon, 03 Aug 2026 10:38:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hDCnB2Lc0z3FVS for ; Mon, 03 Aug 2026 10:38:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785753486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=35SgM4lm+pPeKr5/aldD8oNSOA62DY1JDN3tjtejBII=; b=QLBFhMccMwZ/LnLs8MEdK+izAYxwRvdEbq2EYLZsUSw2MIYwJYBZBTQitWqxFapEzzI3tt p2KkIWtuQ8xZM4/7XaTX5itEGmsmemhh4iTQSF4BdUM1/Lqfng/zYR2Ocxs3x792xBQTQy Bbnsf+U7sVRD3HOcZBsd7YvioBLP2zW+tGa+epQnO7ZQa5vJkDq0GGcBlx1MHeBf2afxb6 PlJhMU9SAGgF304ozJclCSLDSWashNAQ35fBlKHrJVNZSpty+PocGAjFTxGGl5/5yNAxeC 56Ua+rkHuKovq14snAE2UAJBMXwL53V55XGBiH1BJfSo53kp4KK5Gr2boKr3aQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785753486; a=rsa-sha256; cv=none; b=ifaGGoQa4dgyd9jE9c4wbib2ukCJjBnRKG9uSc3HRJ82OMD+9st7zTRMhFqEzJkl8ugavk CeVGPuwmXgtIA/AMo+apXPVRONtVzOZ1/R/PdtFOoNU66bkaQt7a9ct0Cn4pttYN/Ohnae STNfWCCuFmlBGqbXJaL0WdOW2WfaX0nvJIWcUtdlogy9e1rXCtlcN6Ne3t3xjd87m1wJ2n AdHJKEzWCviTNbxGCEPh/Yuz4TKkjVpXQ7uWAL5gD5G/y+yUa/DQOmSzpITBMyqu9UJX3Y 7VRcfv1e6prLZVd8Ua/ZrXr23ch4oLFE2neZepmeIsaBG6M8O9w72A76oiKXmg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785753486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=35SgM4lm+pPeKr5/aldD8oNSOA62DY1JDN3tjtejBII=; b=VhPS0P/+V9uEsp0HX2DXaC1aDhYq12tqfyfU2FQn2AEJOMEEGctbWPRr1H9LyKKYSaUVnT aDwRZYca0jByQFQHQ80nxCfrWYnBU/zYEyKkq8yCPAmvrEo559rnacI+S026nikDM9Ei5Y oUsy5dbwxC+dPA6z+HOMtpS1RXbRJB4jlV1ADFzQ9+CU/S1NjlGg1szh38ftScU01TlTPC S3uLW0fmoqXK+SPcnyPDK2X7e1ysafTxDRDLaCtHeGd59qtKg2qMnJ2eNZt9eQj+cB7elu H/I7bvY+29Rtth+bHBJdGrJp8mzHoPlYovzUZtcpFxGO13YNA1GwW64BEPHX5g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hDCnB0Wwlzwx8 for ; Mon, 03 Aug 2026 10:38:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 4471d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 03 Aug 2026 10:38:05 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kevin Bowling Subject: git: 709426551c6a - main - igc: Work around I225 v1 minimum IPG erratum List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 709426551c6a3607fb5a33f5b8dbb87cfa9c8125 Auto-Submitted: auto-generated Date: Mon, 03 Aug 2026 10:38:05 +0000 Message-Id: <6a706f8d.4471d.5271f968@gitrepo.freebsd.org> The branch main has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=709426551c6a3607fb5a33f5b8dbb87cfa9c8125 commit 709426551c6a3607fb5a33f5b8dbb87cfa9c8125 Author: Kevin Bowling AuthorDate: 2026-08-03 10:28:49 +0000 Commit: Kevin Bowling CommitDate: 2026-08-03 10:37:09 +0000 igc: Work around I225 v1 minimum IPG erratum I225 v1 cannot receive the minimum inter-packet gap required at 2.5 Gb/s. For affected back-to-back links, Intel recommends using a 15-byte transmit IPG instead of 12 bytes. Program TIPG.IPGT to 0xb for pre-v2 I225 devices at 2.5 Gb/s and restore the default at lower speeds. Avoid penalizing fixed I225 and I226 parts. MFC after: 2 weeks --- sys/dev/igc/if_igc.c | 29 +++++++++++++++++++++++++++++ sys/dev/igc/igc_defines.h | 1 + 2 files changed, 30 insertions(+) diff --git a/sys/dev/igc/if_igc.c b/sys/dev/igc/if_igc.c index 4a54d8ca7a6c..fa4f427a5710 100644 --- a/sys/dev/igc/if_igc.c +++ b/sys/dev/igc/if_igc.c @@ -128,6 +128,7 @@ static int igc_if_rx_queue_intr_enable(if_ctx_t, uint16_t); static int igc_if_tx_queue_intr_enable(if_ctx_t, uint16_t); static void igc_if_multi_set(if_ctx_t); static void igc_if_update_admin_status(if_ctx_t); +static void igc_apply_i225_ipg_workaround(struct igc_softc *); static void igc_if_debug(if_ctx_t); static void igc_update_stats_counters(struct igc_softc *); static void igc_add_hw_stats(struct igc_softc *); @@ -1400,6 +1401,33 @@ igc_if_timer(if_ctx_t ctx, uint16_t qid) iflib_admin_intr_deferred(ctx); } +static void +igc_apply_i225_ipg_workaround(struct igc_softc *sc) +{ + struct igc_hw *hw = &sc->hw; + u32 ipgt, tipg; + + /* + * I225 v1 cannot receive the minimum IPG required at 2.5 Gb/s. + * Intel's documented back-to-back workaround is for the transmitter + * to use a 15-byte IPG instead of 12 bytes. I225 v2 and later have + * the receive-side fix and should retain the standard IPG. + */ + if (!igc_is_device_id_i225(hw) || + hw->revision_id >= IGC_REVISION_2) + return; + + ipgt = sc->link_speed == SPEED_2500 ? IGC_I225_TIPG_IPGT_2P5 : + DEFAULT_82543_TIPG_IPGT_COPPER; + tipg = IGC_READ_REG(hw, IGC_TIPG); + if ((tipg & IGC_TIPG_IPGT_MASK) == ipgt) + return; + + tipg &= ~IGC_TIPG_IPGT_MASK; + tipg |= ipgt; + IGC_WRITE_REG(hw, IGC_TIPG, tipg); +} + static void igc_if_update_admin_status(if_ctx_t ctx) { @@ -1445,6 +1473,7 @@ igc_if_update_admin_status(if_ctx_t ctx) sc->link_active = 0; iflib_link_state_change(ctx, LINK_STATE_DOWN, 0); } + igc_apply_i225_ipg_workaround(sc); igc_update_stats_counters(sc); } diff --git a/sys/dev/igc/igc_defines.h b/sys/dev/igc/igc_defines.h index 09f75fe2787e..3e6309176204 100644 --- a/sys/dev/igc/igc_defines.h +++ b/sys/dev/igc/igc_defines.h @@ -364,6 +364,7 @@ /* Default values for the transmit IPG register */ #define DEFAULT_82543_TIPG_IPGT_FIBER 9 #define DEFAULT_82543_TIPG_IPGT_COPPER 8 +#define IGC_I225_TIPG_IPGT_2P5 0xB #define IGC_TIPG_IPGT_MASK 0x000003FF