From owner-freebsd-bugs  Wed Aug 22 16:41: 5 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 826C037B410
	for <freebsd-bugs@hub.freebsd.org>; Wed, 22 Aug 2001 16:40:28 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f7MNeSl89393;
	Wed, 22 Aug 2001 16:40:28 -0700 (PDT)
	(envelope-from gnats)
Received: from mail.newgold.net (aphex.newgold.net [209.42.222.44])
	by hub.freebsd.org (Postfix) with SMTP id 5C23B37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 22 Aug 2001 16:37:45 -0700 (PDT)
	(envelope-from jmallett@mail.newgold.net)
Received: (qmail 37869 invoked by uid 1000); 22 Aug 2001 23:37:37 -0000
Message-Id: <20010822233737.37868.qmail@mail.newgold.net>
Date: 22 Aug 2001 23:37:37 -0000
From: Joseph Mallett <jmallett@xMach.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Joseph Mallett <jmallett@xMach.org>
X-Send-Pr-Version: 3.113
Subject: kern/29967: src/sys/net/bpf.c comments are incorrect
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         29967
>Category:       kern
>Synopsis:       bpf code has a misleading comment
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 22 16:40:27 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Joseph Mallett
>Release:        FreeBSD 4.4-RC i386
>Organization:
xMach
>Environment:
System: FreeBSD Aphex.NewGold.NET 4.4-RC FreeBSD 4.4-RC #0: Mon Aug 20 06:41:21 GMT 2001 jmallett@Aphex.NewGold.NET:/usr/people/jmallett/obj i386


	
>Description:
	Ever since some time in ancient history (4.4-lite?), the comment 
for bpfattach has been pretty incorrect when it comes to explaining what 
the parameters are. ifp is not explained, and driverp (which is no longer 
present in FreeBSD) is still explained.

>How-To-Repeat:
	vi /sys/net/bpf.c
	:/bpfattach/
>Fix:
--- bpf.orig    Wed Aug 22 23:31:16 2001
+++ bpf.c       Wed Aug 22 23:33:27 2001
@@ -1272,9 +1272,10 @@
 }

 /*
- * Attach an interface to bpf.  driverp is a pointer to a (struct bpf_if 
*)
- * in the driver's softc; dlt is the link layer type; hdrlen is the fixed
- * size of the link header (variable length headers not yet supported).
+ * Attach an interface to bpf. ifp is a pointer to the structure defining
+ * the interface to be attached; dlt is the link layer type; hdrlen is 
the
+ * fixed size of the link header (variable length headers are not
+ * supported, yet.)
  */
 void
 bpfattach(ifp, dlt, hdrlen)
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message