Date: Sat, 15 Oct 2016 10:10:46 -0500 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306346 - head/sys/kern Message-ID: <c8014d3a-2d12-8843-e529-7221e722c69b@FreeBSD.org> In-Reply-To: <20161004205600.GN23123@FreeBSD.org> References: <201609261530.u8QFUUZd020174@repo.freebsd.org> <20161004205600.GN23123@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 10/04/2016 15:56, Gleb Smirnoff wrote:
> Eric,
>
> E> @@ -924,7 +924,7 @@ __mtx_assert(const volatile uintptr_t *c
> E> {
> E> const struct mtx *m;
> E>
> E> - if (panicstr != NULL || dumping)
> E> + if (panicstr != NULL || dumping || SCHEDULER_STOPPED())
> E> return;
>
> I wonder if all this disjunct can be reduced just to SCHEDULER_STOPPED()?
> Positive panicstr and dumping imply scheduler stopped.
If I read correctly, that's /almost/ true, but the scheduler is only stopped
#ifdef SMP and we're panicking, so we need the full expression to cover the !SMP
and reboot(RB_DUMP) cases.
Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c8014d3a-2d12-8843-e529-7221e722c69b>