From owner-freebsd-stable@freebsd.org Sun May 27 20:22:52 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A2AFF7F0C9 for ; Sun, 27 May 2018 20:22:52 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 982316CD2E for ; Sun, 27 May 2018 20:22:51 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.0.6] (67-0-245-183.albq.qwest.net [67.0.245.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id F02E9192889; Sun, 27 May 2018 12:32:35 +0000 (UTC) Subject: Re: r334229 breaks build kernel To: junchoon@dec.sakura.ne.jp, freebsd-stable@freebsd.org Cc: supportme@ukr.net, david@catwhisker.org, imp@bsdimp.com References: <1527346385.620374207.gguw32a1@frv33.fwdcdn.com> <20180527151853.a8cbb9c0f68ab678f6082e63@dec.sakura.ne.jp> From: Sean Bruno Openpgp: preference=signencrypt Autocrypt: addr=sbruno@freebsd.org; prefer-encrypt=mutual; keydata= xsBNBFk+0UEBCADaf4bgxxKvMOhRV5NPoGWRCCGm49d6+1VFNlQ77WsY/+Zvf95TPULdRlnG w648KfxWt7+O3kdKhdRwnqlXWC7zA2Qt0dRE1yIqOGJ4jp4INvp/bcxWzgr0aoKOjrlnfxRV bh+s0rzdZt6TsNL3cVYxkC8oezjaUkHdW4mFJU249U1QJogkF8g0FeKNfEcjEkwJNX6lQJH+ EzCWT0NCk6J+Xyo+zOOljxPp1OUfdvZi3ulkU/qTZstGVWxFVsP8xQklV/y3AFcbIYx6iGJ4 5L7WuB0IWhO7Z4yHENr8wFaNYwpod9i4egX2BugbrM8pOfhN2/qqdeG1L5LMtXw3yyAhABEB AAHNN1NlYW4gQnJ1bm8gKEZyZWVCU0QgRGV2ZWxvcGVyIEtleSkgPHNicnVub0BmcmVlYnNk Lm9yZz7CwJQEEwEKAD4WIQToxOn4gDUE4eP0ujS95PX+ibX8tgUCWT7RQQIbAwUJBaOagAUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAAKCRC95PX+ibX8ttKTCACFKzRc56EBAlVotq02EjZP SfX+unlk6AuPBzShxqRxeK+bGYVCigrYd1M8nnskv0dEiZ5iYeND9HIxbpEyopqgpVTibA7w gBXaZ7SOEhNX1wXwg14JrralfSmPFMYni+sWegPMX/zwfAsn1z4mG1Nn44Xqo3o7CfpkMPy6 M5Bow2IDzIhEYISLR+urxs74/aHU35PLtBSDtu18914SEMDdva27MARN8mbeCDbuJVfGCPWy YHuy2t+9u2Zn5Dd+t3sBXLM9gpeaMm+4x6TNPpESygbVdh4tDdjVZ9DK/bWFg0kMgfZoaq6J l0jNsQXrZV3bzYNFbVw04pFcvA2GIJ7xzsBNBFk+0UEBCADIXBmQOaKMHGbc9vwjhV4Oj5aZ DdhNedn12FVeTdOXJvuTOusgxS29lla0RenHGDsgD08UiFpasBXWq/E+BhQ19d+iRbLLR17O KKc1ZGefoVbLARLXD68J5j4XAyK+6k2KqBLlqzAEpHTzsksM9naARkVXiEVcrt6ciw0FSm8n kuK3gDKKe93XfzfP+TQdbvvzJc7Fa+appLbXz61TM1aikaQlda8bWubDegwXbuoJdB34xU1m yjr/N4o+raL0x7QrzdH+wwgrTTo+H4S2c1972Skt5K5tbxLowfHicRl23V8itVQr3sBtlX4+ 66q+Apm7+R36bUS/k+G45Sp6iPpxABEBAAHCwHwEGAEKACYWIQToxOn4gDUE4eP0ujS95PX+ ibX8tgUCWT7RQQIbDAUJBaOagAAKCRC95PX+ibX8trrIB/9Pljqt/JGamD9tx4dOVmxSyFg9 z2xzgklTLuDgS73MM120mM7ao9AQUeWiSle/H0UCK7xPOzC/aeUC4oygDQKAfkkNbCNTo3+A qDjBRA8qx0e9a/QjDL+RFgD4L5kLT4tToY8T8HaBp8h03LBfk510IaI8oL/Jg7vpM3PDtJMW tUi2H+yNFmL3NfM2oBToWKLFsoP54f/eeeImrNnrlLjLHPzqS+/9apgYqX2Jwiv3tHBc4FTO GuY8VvF7BpixJs8Pc2RUuCfSyodrp1YG1kRGlXAH0cqwwr0Zmk4+7dZvtVQMCl6kS6q1+84q JwtItxS2eXSEA4NO0sQ3BXUywANh Message-ID: <30d3e0ec-7443-3e5e-5a3a-9683427db579@freebsd.org> Date: Sun, 27 May 2018 14:22:46 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180527151853.a8cbb9c0f68ab678f6082e63@dec.sakura.ne.jp> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0jvRCzBYS4cbfz3be5NKMgMO3nkXxa91D" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2018 20:22:52 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0jvRCzBYS4cbfz3be5NKMgMO3nkXxa91D Content-Type: multipart/mixed; boundary="Q55IbqPd8lpJA0SRRxniQwHkou2D27Cdr"; protected-headers="v1" From: Sean Bruno To: junchoon@dec.sakura.ne.jp, freebsd-stable@freebsd.org Cc: supportme@ukr.net, david@catwhisker.org, imp@bsdimp.com Message-ID: <30d3e0ec-7443-3e5e-5a3a-9683427db579@freebsd.org> Subject: Re: r334229 breaks build kernel References: <1527346385.620374207.gguw32a1@frv33.fwdcdn.com> <20180527151853.a8cbb9c0f68ab678f6082e63@dec.sakura.ne.jp> In-Reply-To: <20180527151853.a8cbb9c0f68ab678f6082e63@dec.sakura.ne.jp> --Q55IbqPd8lpJA0SRRxniQwHkou2D27Cdr Content-Type: text/plain; charset=iso-2022-jp Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 05/27/18 00:18, Tomoaki AOKI wrote: > Looks simple mis-merge. > On hunk 1, original (head) r323831 has "hz / isc->quanta" at 2nd arg, > while r334229 (stable/11) has "hz / isc->quanta1". >=20 > r334228 and before had "hz / isc->quanta - 1", so missingly removed > " - " instead of " - 1". >=20 > Any other hunks looks fine. >=20 > Regards. >=20 > On Sat, 26 May 2018 10:37:34 -0600 > Warner Losh wrote: >=20 >> Looks like sean's merge was incomplete somehow. >> >> Warner >> >> On Sat, May 26, 2018 at 9:02 AM, Dmitriy Makarov w= rote: >> >>> Hi, >>> >>> probably this last changes https://svnweb.freebsd.org/ >>> base?view=3Drevision&revision=3D334229 breaks buildkernel in stable/1= 1 >>> >>> If it is related my kernel config contains IOSCHED option: >>> options CAM_IOSCHED_DYNAMIC >>> >>> >>> cc -target x86_64-unknown-freebsd11.2 --sysroot=3D/usr/obj/usr/src/tm= p >>> -B/usr/obj/usr/src/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasing -g >>> -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL= >>> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-omit-frame-p= ointer >>> -mno-omit-leaf-frame-pointer -MD -MF.depend.cam_iosched.o -MTcam_ios= ched.o >>> -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float >>> -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protec= tor >>> -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototype= s >>> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef >>> -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-includ= e-dirs >>> -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautologica= l-compare >>> -Wno-error-empty-body -Wno-error-parentheses-equality >>> -Wno-error-unused-function -Wno-error-pointer-sign >>> -Wno-error-shift-negative-value -Wno-error-address-of-packed-member >>> -mno-aes -mno-avx -std=3Diso9899:1999 -W >>> error /usr/src/sys/cam/cam_iosched.c >>> >>> /usr/src/sys/cam/cam_iosched.c:513:40: error: no member named 'quanta= 1' >>> in 'struct cam_iosched_softc'; did you mean 'quanta'? >>> callout_reset(&isc->ticker, hz / isc->quanta1, cam_iosched_ti= cker, >>> isc); >>> ^~~~~~~ >>> quanta >>> /usr/src/sys/sys/callout.h:115:28: note: expanded from macro >>> 'callout_reset' >>> callout_reset_on((c), (on_tick), (fn), (arg), -1) >>> ^ >>> /usr/src/sys/sys/callout.h:112:43: note: expanded from macro >>> 'callout_reset_on' >>> callout_reset_sbt_on((c), tick_sbt * (to_ticks), 0, (fn), (arg), = \ >>> ^ >>> /usr/src/sys/cam/cam_iosched.c:267:7: note: 'quanta' declared here >>> int quanta; /* Number of quanta p= er >>> second */ >>> ^ >>> 1 error generated. >>> _______________________________________________ >>> freebsd-stable@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/freebsd-stable >>> To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.= org" >>> >> _______________________________________________ >> freebsd-stable@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-stable >> To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.o= rg" >> >=20 >=20 I'm looking at this. sean --Q55IbqPd8lpJA0SRRxniQwHkou2D27Cdr-- --0jvRCzBYS4cbfz3be5NKMgMO3nkXxa91D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAlsLE5dfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LZiAwf+JWqmrkGIBBnBrPWOu8E40bV2nnbz65Pu7QZF37ejuXV2Z4kpYyqex6qF g0vM2g/nTe1G87XuBK/hTwAAF2ORm1mynCN2ygq/+ycrgHjZMeh1/apk0Rwec9/R RgRXy4egM4TGmOv3iSCa9tEOQpMpr9OeC7G0pOc80P7qz9+4kEZ9pziENfw7bNUF WdBsJweDsceWmlfnsekAbzy8YW8F81lZb2K1Yqw5o/i3rNd7bzsMagb3BHkEM9ys aluJjr0sD918OVKF710zwhjM4Xf+q19/BAzu7BPNDKyGjTHFhxkvU84MrYKMorzU RQGbTQl06OHNLLt3UKv4z6YqjRntiw== =SW7l -----END PGP SIGNATURE----- --0jvRCzBYS4cbfz3be5NKMgMO3nkXxa91D--