From owner-freebsd-multimedia@FreeBSD.ORG Tue Dec 13 04:18:46 2005 Return-Path: X-Original-To: freebsd-multimedia@freebsd.org Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3ABA716A41F for ; Tue, 13 Dec 2005 04:18:46 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.197]) by mx1.FreeBSD.org (Postfix) with ESMTP id C403143D55 for ; Tue, 13 Dec 2005 04:18:44 +0000 (GMT) (envelope-from pyunyh@gmail.com) Received: by zproxy.gmail.com with SMTP id o1so1644634nzf for ; Mon, 12 Dec 2005 20:18:44 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=kVBPjm++BcrJoQ9kabMAhS5kp6e0haBCkYJmVKu8mhfbD/I4h+RGADO94E/pKkavtqlmGALW6OcRPcAqaLGZLHEcU0B4hDcqjHjf1CiwnWD9z1sS8BZ5b97XB9oIPAWc4oPZ8WN82SA4OBOZD9gUT9cresfrqdXO4Kg3D3p/bCk= Received: by 10.36.39.9 with SMTP id m9mr6738217nzm; Mon, 12 Dec 2005 20:18:44 -0800 (PST) Received: from michelle.rndsoft.co.kr ( [211.32.202.217]) by mx.gmail.com with ESMTP id 10sm10520268nzo.2005.12.12.20.18.42; Mon, 12 Dec 2005 20:18:43 -0800 (PST) Received: from michelle.rndsoft.co.kr (localhost.rndsoft.co.kr [127.0.0.1]) by michelle.rndsoft.co.kr (8.13.5/8.13.5) with ESMTP id jBD4IVNn006810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Dec 2005 13:18:31 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.rndsoft.co.kr (8.13.5/8.13.5/Submit) id jBD4IU06006809; Tue, 13 Dec 2005 13:18:30 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Tue, 13 Dec 2005 13:18:30 +0900 From: Pyun YongHyeon To: "Steven S." Message-ID: <20051213041830.GB5920@rndsoft.co.kr> References: <200512030310.jB33A77R038278@freefall.freebsd.org> <20051203092819.GB13672@rndsoft.co.kr> <20051204181714.C728@atlantis.403forbidden.net> <20051205060208.GC1086@rndsoft.co.kr> <20051205202824.C45817@atlantis.403forbidden.net> <20051212030939.GA1093@rndsoft.co.kr> <20051212201440.G701@atlantis.403forbidden.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="82I3+IH0IqGh5yIs" Content-Disposition: inline In-Reply-To: <20051212201440.G701@atlantis.403forbidden.net> User-Agent: Mutt/1.4.2.1i Cc: freebsd-multimedia@freebsd.org Subject: Re: kern/63204: [sound] /dev/mixer broken with ESS Maestro-2E (still on 5.4) X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2005 04:18:46 -0000 --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 12, 2005 at 08:24:03PM -0500, Steven S. wrote: > > > same problem. no mixer devices, no sound. > I guess the codec may need some special handling. Please apply attached patch too. Did it make any difference? -- Regards, Pyun YongHyeon --82I3+IH0IqGh5yIs Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="ac97.patch.1213" --- sys/dev/sound/pcm/ac97.c.orig Tue Dec 13 09:29:05 2005 +++ sys/dev/sound/pcm/ac97.c Tue Dec 13 13:12:08 2005 @@ -317,10 +317,30 @@ return AC97_READ(codec->methods, codec->devinfo, reg); } +static int +ac97_valid_reg(struct ac97_info *codec, int reg) +{ + + switch (codec->id) { + case 0x414b4d00: /* AK4540 */ + case 0x414b4d01: /* AK4542 */ + if (reg <= 0x1c || reg == 0x20 || reg == 0x26 || reg >= 0x7c) + return 1; + return 0; + /* NOTREACHED */ + break; + default: + break; + } + + return 1; +} + void ac97_wrcd(struct ac97_info *codec, int reg, u_int16_t val) { - AC97_WRITE(codec->methods, codec->devinfo, reg, val); + if (ac97_valid_reg(codec, reg)) + AC97_WRITE(codec->methods, codec->devinfo, reg, val); } static void --82I3+IH0IqGh5yIs--