From owner-freebsd-current@freebsd.org  Thu Jan  7 16:53:33 2016
Return-Path: <owner-freebsd-current@freebsd.org>
Delivered-To: freebsd-current@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6824FA66500
 for <freebsd-current@mailman.ysv.freebsd.org>;
 Thu,  7 Jan 2016 16:53:33 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com
 [IPv6:2607:f8b0:4001:c06::22c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 37CA51A76;
 Thu,  7 Jan 2016 16:53:33 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: by mail-io0-x22c.google.com with SMTP id g73so60307790ioe.3;
 Thu, 07 Jan 2016 08:53:33 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=tThPFKA/AK+vB++fpsqPVNdF+guoY0whRZIhzuCoS4k=;
 b=KyuVRWnEqWfs9ggYiT8xo7t0JYnVC1O1nXeXFVE4aQf0L+62l74H1PjwaoOCEwwjwG
 +IawK/UUGP3oZK1Eyp35HrS1xzJSxVL79R46KJznjMwcCxGDsyDcZhnqYReIRbux4zAm
 /dW4lTl85T/umIxBue1SesDFYNgRMDvXa9M4FukWZ9DP2hYCrgvipynMeKdk+7qWJXz1
 qRVpSVyV7wRgnBSe8N5Rof0Mso8a69Zfvg5T8KeO/5TgF0IQiCoxByk4+feKWVFld8d9
 upfWdaTNi1sE8OhgalMn4RkrL9X6qCirdET0961IIuAXrmrMvgjJmwr2rWkZqXRpMyH7
 0S+A==
MIME-Version: 1.0
X-Received: by 10.107.162.146 with SMTP id l140mr40455078ioe.123.1452185612671; 
 Thu, 07 Jan 2016 08:53:32 -0800 (PST)
Received: by 10.36.121.202 with HTTP; Thu, 7 Jan 2016 08:53:32 -0800 (PST)
In-Reply-To: <201601070947.u079lWFk066644@slippy.cwsent.com>
References: <jlh@FreeBSD.org>
 <CAGSa5y0QiKV9SgJYJ_mz3SnJGNjieHSvYP8nLjt9eWXo4RU6ww@mail.gmail.com>
 <201601070947.u079lWFk066644@slippy.cwsent.com>
Date: Thu, 7 Jan 2016 08:53:32 -0800
Message-ID: <CAJ-VmonGOs2f+rzciEcV=VuaNrZt0hqNePQx4LZDWu6BxuR9NQ@mail.gmail.com>
Subject: Re: Panic from vesa_configure()
From: Adrian Chadd <adrian.chadd@gmail.com>
To: Cy Schubert <Cy.Schubert@komquats.com>
Cc: Jeremie Le Hen <jlh@freebsd.org>, Ryan Stone <rysto32@gmail.com>, 
 FreeBSD Current <freebsd-current@freebsd.org>, 
 =?UTF-8?B?SmVhbi1Tw6liYXN0aWVuIFDDqWRyb24=?= <dumbbell@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Jan 2016 16:53:33 -0000

Ok,

So try adding this check:

vmbuf = x86bios_alloc(&offs, sizeof(*buf), M_WAITOK);
if (vmbuf == NULL) {
    printf("%s: x86bios_alloc failed!\n", __func__);
    goto fail;
}

... that call shouldn't be failing, but if it's truely failing on the
bcopy(), the only reason is because vmbuf is NULL.


-a