From owner-freebsd-arch@FreeBSD.ORG  Fri Jul  1 14:38:51 2005
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
X-Original-To: freebsd-arch@FreeBSD.org
Delivered-To: freebsd-arch@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5B79416A41C;
	Fri,  1 Jul 2005 14:38:51 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1726443D48;
	Fri,  1 Jul 2005 14:38:48 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.3/8.13.3) with ESMTP id j61EkB31086711;
	Fri, 1 Jul 2005 08:46:11 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <42C554C2.5050304@samsco.org>
Date: Fri, 01 Jul 2005 08:35:46 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Xin LI <delphij@frontfree.net>
References: <20050701111103.GA48039@frontfree.net>
In-Reply-To: <20050701111103.GA48039@frontfree.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-2.8 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.2
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on pooker.samsco.org
Cc: re@FreeBSD.org, freebsd-arch@FreeBSD.org
Subject: Re: [PATCH] Remove ENABLE_SSE option from i386 and pc98
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jul 2005 14:38:51 -0000

Xin LI wrote:

> Hi,
> 
> Here is a patch for review, which removes ENABLE_SSE from i386 and
> pc98 platforms.  I think we should have it before we branch RELENG_6.
> 
> The reason why the option should be removed:
> 
> 	- ENABLE_SSE was turned on by default 2 years and 9 months
> 	  ago, for I686_CPU.  It makes few sense to "enable" something
> 	  that is already enabled (No I586_CPUs supports SSE so far
> 	  as I am aware)
> 	- We have DISABLE_SSE to disable SSE, having both ENABLE_SSE
> 	  and DISABLE_SSE is quite confusing, since DISABLE_SSE
> 	  always overrides ENABLE_SSE.
> 
> Cheers,

Approved.  Please commit it today if possible.

Scott