From owner-freebsd-current Tue Oct 1 16:41:21 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19F9137B401; Tue, 1 Oct 2002 16:41:19 -0700 (PDT) Received: from tasogare.imasy.or.jp (tasogare.imasy.or.jp [202.227.24.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5500543E42; Tue, 1 Oct 2002 16:41:17 -0700 (PDT) (envelope-from iwasaki@jp.FreeBSD.org) Received: from localhost (iwa@tasogare.imasy.or.jp [202.227.24.5]) by tasogare.imasy.or.jp (8.11.6+3.4W/8.11.6/tasogare) with ESMTP/inet id g91NfEY91525; Wed, 2 Oct 2002 08:41:14 +0900 (JST) (envelope-from iwasaki@jp.FreeBSD.org) Date: Wed, 02 Oct 2002 08:41:10 +0900 (JST) Message-Id: <20021002.084110.69705085.iwasaki@jp.FreeBSD.org> To: jhb@FreeBSD.ORG Cc: mmcgoldrick@linuxdriven.net, current@FreeBSD.ORG Subject: Re: PCI brokenness From: Mitsuru IWASAKI In-Reply-To: References: <20021001211543.GA607@uriel.fakedomain.net> X-Mailer: Mew version 2.2 on Emacs 20.7 / Mule 4.0 (HANANOEN) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, > On 01-Oct-2002 Michael McGoldrick wrote: > > On Tue, Oct 01, 2002 at 12:48:47PM -0400, John Baldwin wrote: > >> > >> On 01-Oct-2002 Michael McGoldrick wrote: > >> > 'Me too' > >> > Dmesg from working kernel attached, not sure how to get a dmesg from the > >> > broken one. :( > >> > Send me a mail if any further info would help. > >> > (I have built two kernels recently, both have had this problem) > >> > >> What exact problem do you have. No PCI devices? > >> > >> -- > >> > >> John Baldwin <>< http://www.FreeBSD.org/~jhb/ > >> "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ > >> > >> To Unsubscribe: send mail to majordomo@FreeBSD.org > >> with "unsubscribe freebsd-current" in the body of the message > > > > Yes, the kernel seems to attempt to mount root right after this line: > > device_probe_and_attach: acpi0 attach returned 6 > > Can you try with the stuff I committed yesterday? It fixed the case (for > my tests at least) of legacy0 failing to attach or probe when acpi failed > to attach. If still failed, please try this. I've noticed that no chance to call pci_cfgregopen() before probing PCI children in case Host PCI bridge _CRS is not method or _INI method don't access to PCI config space or something. Thanks Index: acpi_pcib_acpi.c =================================================================== RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v retrieving revision 1.23 diff -u -r1.23 acpi_pcib_acpi.c --- acpi_pcib_acpi.c 26 Aug 2002 18:30:27 -0000 1.23 +++ acpi_pcib_acpi.c 1 Oct 2002 23:17:51 -0000 @@ -114,6 +115,9 @@ !acpi_disabled("pci") && acpi_MatchHid(dev, "PNP0A03")) { + if (!pci_cfgregopen()) + return(ENXIO); + /* * Set device description */ Index: acpi_pcib_pci.c =================================================================== RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_pci.c,v retrieving revision 1.1 diff -u -r1.1 acpi_pcib_pci.c --- acpi_pcib_pci.c 26 Aug 2002 18:30:27 -0000 1.1 +++ acpi_pcib_pci.c 1 Oct 2002 23:18:38 -0000 @@ -114,6 +115,9 @@ return (ENXIO); if (acpi_get_handle(dev) == NULL) return (ENXIO); + if (!pci_cfgregopen()) + return (ENXIO); + device_set_desc(dev, "ACPI PCI-PCI bridge"); return (-1000); } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message