From owner-freebsd-bugs  Wed Nov  1 23:10: 7 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id EFFCC37B479
	for <freebsd-bugs@FreeBSD.org>; Wed,  1 Nov 2000 23:10:01 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id XAA88243;
	Wed, 1 Nov 2000 23:10:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from yeti.ismedia.pl (yeti.ismedia.pl [212.182.117.178])
	by hub.freebsd.org (Postfix) with SMTP id 7298437B4C5
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  1 Nov 2000 23:08:43 -0800 (PST)
Received: (qmail 5860 invoked from network); 2 Nov 2000 07:08:43 -0000
Received: from unknown (HELO lagoon.freebsd.lublin.pl) (212.182.115.11)
  by 0 with SMTP; 2 Nov 2000 07:08:43 -0000
Received: (qmail 35852 invoked from network); 2 Nov 2000 07:09:35 -0000
Received: from unknown (HELO riget.scene.pl) (212.182.115.2)
  by 0 with SMTP; 2 Nov 2000 07:09:35 -0000
Received: (qmail 16163 invoked by uid 1001); 2 Nov 2000 07:08:27 -0000
Message-Id: <20001102070827.16162.qmail@riget.scene.pl>
Date: 2 Nov 2000 07:08:27 -0000
From: venglin@freebsd.lublin.pl
Reply-To: venglin@freebsd.lublin.pl
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/22496: [SECURITY] Yet another top(1) format string vulnerability
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         22496
>Category:       bin
>Synopsis:       [SECURITY] Yet another top(1) format string vulnerability
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 01 23:10:01 PST 2000
>Closed-Date:
>Last-Modified:
>Originator:     Przemyslaw Frasunek
>Release:        FreeBSD 4.1.1-STABLE i386
>Organization:
ISMEDIA
>Environment:

FreeBSD 4.1.1-STABLE as of 2 November 2000.

>Description:

	Vulnerability very similar to FreeBSD-SA-00:62, just few lines below
	in top.c, but still not fixed.

>How-To-Repeat:

	1. Run top
	2. Press 'r'
	3. Type '20 %n'
	4. Segfault

>Fix:

--- top.c.old	Thu Nov  2 08:07:29 2000
+++ top.c	Thu Nov  2 08:08:17 2000
@@ -826,7 +826,7 @@
 				{
 				    if ((errmsg = renice_procs(tempbuf2)) != NULL)
 				    {
-					new_message(MT_standout, errmsg);
+					new_message(MT_standout, "%s", errmsg);
 					putchar('\r');
 					no_command = Yes;
 				    }

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message