Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 Dec 2012 18:54:35 -0800
From:      Adrian Chadd <adrian@freebsd.org>
To:        Nathan Whitehorn <nwhitehorn@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r244865 - in head: . lib lib/libdisk share/mk
Message-ID:  <CAJ-VmokddSkDgBJWwbtzyMWENgK45NS6r8JcJecvyLLxvnf26Q@mail.gmail.com>
In-Reply-To: <201212301628.qBUGS6tE037193@svn.freebsd.org>
References:  <201212301628.qBUGS6tE037193@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
.. not that I mind old things being retired, but we really should
announce things like this.

Also - you disconnected libftpio too; is that intentional?

Just because libdisk/libftpio isn't used by anything in the base -HEAD
doesn't mean that:

* it's not used by third party programs in ports;
* it's not used by any external, non open source utilities that people
have read.

So I'd suggest creating a port for them both and begin the process of
deprecating the kernel side interfaces that are unique to this API.

Thanks,



Adrian


On 30 December 2012 08:28, Nathan Whitehorn <nwhitehorn@freebsd.org> wrote:
> Author: nwhitehorn
> Date: Sun Dec 30 16:28:06 2012
> New Revision: 244865
> URL: http://svnweb.freebsd.org/changeset/base/244865
>
> Log:
>   With the old sade removed, libdisk is no longer used by anything in HEAD
>   and uses a number of problematic pre-gpart interfaces. Since it has been
>   entirely obsoleted by interfaces in geom, remove it.
>
> Deleted:
>   head/lib/libdisk/
> Modified:
>   head/ObsoleteFiles.inc
>   head/lib/Makefile
>   head/share/mk/bsd.libnames.mk
>
> Modified: head/ObsoleteFiles.inc
> ==============================================================================
> --- head/ObsoleteFiles.inc      Sun Dec 30 15:38:06 2012        (r244864)
> +++ head/ObsoleteFiles.inc      Sun Dec 30 16:28:06 2012        (r244865)
> @@ -38,6 +38,9 @@
>  #   xargs -n1 | sort | uniq -d;
>  # done
>
> +# 20121230: libdisk removed
> +OLD_FILES+=usr/share/man/man3/libdisk.3.gz usr/include/libdisk.h
> +OLD_FILES+=usr/lib/libdisk.a usr/lib32/libdisk.a
>  # 20121230: remove wrongly created directories for auditdistd
>  OLD_DIRS+=var/dist
>  OLD_DIRS+=var/remote
>
> Modified: head/lib/Makefile
> ==============================================================================
> --- head/lib/Makefile   Sun Dec 30 15:38:06 2012        (r244864)
> +++ head/lib/Makefile   Sun Dec 30 16:28:06 2012        (r244865)
> @@ -69,7 +69,6 @@ SUBDIR=       ${SUBDIR_ORDERED} \
>         libcompat \
>         libdevinfo \
>         libdevstat \
> -       libdisk \
>         libdwarf \
>         libedit \
>         ${_libefi} \
>
> Modified: head/share/mk/bsd.libnames.mk
> ==============================================================================
> --- head/share/mk/bsd.libnames.mk       Sun Dec 30 15:38:06 2012        (r244864)
> +++ head/share/mk/bsd.libnames.mk       Sun Dec 30 16:28:06 2012        (r244865)
> @@ -45,7 +45,6 @@ LIBCURSES?=   ${DESTDIR}${LIBDIR}/libcurse
>  LIBDEVINFO?=   ${DESTDIR}${LIBDIR}/libdevinfo.a
>  LIBDEVSTAT?=   ${DESTDIR}${LIBDIR}/libdevstat.a
>  LIBDIALOG?=    ${DESTDIR}${LIBDIR}/libdialog.a
> -LIBDISK?=      ${DESTDIR}${LIBDIR}/libdisk.a
>  LIBDNS?=       ${DESTDIR}${LIBDIR}/libdns.a
>  LIBDTRACE?=    ${DESTDIR}${LIBDIR}/libdtrace.a
>  LIBDWARF?=     ${DESTDIR}${LIBDIR}/libdwarf.a
> @@ -54,7 +53,6 @@ LIBELF?=      ${DESTDIR}${LIBDIR}/libelf.a
>  LIBFETCH?=     ${DESTDIR}${LIBDIR}/libfetch.a
>  LIBFL?=                "don't use LIBFL, use LIBL"
>  LIBFORM?=      ${DESTDIR}${LIBDIR}/libform.a
> -LIBFTPIO?=     ${DESTDIR}${LIBDIR}/libftpio.a
>  LIBG2C?=       ${DESTDIR}${LIBDIR}/libg2c.a
>  LIBGCC?=       ${DESTDIR}${LIBDIR}/libgcc.a
>  LIBGCC_PIC?=   ${DESTDIR}${LIBDIR}/libgcc_pic.a



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmokddSkDgBJWwbtzyMWENgK45NS6r8JcJecvyLLxvnf26Q>