From owner-freebsd-current@FreeBSD.ORG Mon Dec 31 02:54:43 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6F0BACE7; Mon, 31 Dec 2012 02:54:43 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wg0-f47.google.com (mail-wg0-f47.google.com [74.125.82.47]) by mx1.freebsd.org (Postfix) with ESMTP id 59F928FC13; Mon, 31 Dec 2012 02:54:41 +0000 (UTC) Received: by mail-wg0-f47.google.com with SMTP id dq11so5460440wgb.26 for ; Sun, 30 Dec 2012 18:54:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=E2ybxjALRIBmMhkONBfFD0J/Z3j4fDWSljGsLKZ6qRE=; b=LTe/Dntlff+7aQ0p1ZFO9Scvn3TYyF9UWajOtOs1X1q2mAPOOkz1OQtPuvZMpDsJ08 ypEE81l6Fd2Y6CxuIsj+91tKb7ERhnrhQrkM+vcfLDv/uda0V3fT1sxozF+cpNcK59sD xbhjLFhHnmw9vHtFbNnsCt+tLsIU/pL7o5e6ZRDVIW5otJiNnIbsTqE6tESiPAkrkJaK j/jwpSwuVzU+aMGflp3J08GDKiGmukRFiGalg4vDeXkCQEs+35keHd1FuWMjBNxvvCFb yn6/rKUG9JM9XYBQZ7h+2ztAnQhCRkccKWuK/YV3f+nHkFhaxEObXZUQO3rexffFR/0n xm1w== MIME-Version: 1.0 Received: by 10.180.109.201 with SMTP id hu9mr10698114wib.32.1356922475274; Sun, 30 Dec 2012 18:54:35 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.217.57.9 with HTTP; Sun, 30 Dec 2012 18:54:35 -0800 (PST) In-Reply-To: <201212301628.qBUGS6tE037193@svn.freebsd.org> References: <201212301628.qBUGS6tE037193@svn.freebsd.org> Date: Sun, 30 Dec 2012 18:54:35 -0800 X-Google-Sender-Auth: RQjwDM7trmn4JXYVEvOTXIZh_04 Message-ID: Subject: Re: svn commit: r244865 - in head: . lib lib/libdisk share/mk From: Adrian Chadd To: Nathan Whitehorn , freebsd-current Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 02:54:43 -0000 .. not that I mind old things being retired, but we really should announce things like this. Also - you disconnected libftpio too; is that intentional? Just because libdisk/libftpio isn't used by anything in the base -HEAD doesn't mean that: * it's not used by third party programs in ports; * it's not used by any external, non open source utilities that people have read. So I'd suggest creating a port for them both and begin the process of deprecating the kernel side interfaces that are unique to this API. Thanks, Adrian On 30 December 2012 08:28, Nathan Whitehorn wrote: > Author: nwhitehorn > Date: Sun Dec 30 16:28:06 2012 > New Revision: 244865 > URL: http://svnweb.freebsd.org/changeset/base/244865 > > Log: > With the old sade removed, libdisk is no longer used by anything in HEAD > and uses a number of problematic pre-gpart interfaces. Since it has been > entirely obsoleted by interfaces in geom, remove it. > > Deleted: > head/lib/libdisk/ > Modified: > head/ObsoleteFiles.inc > head/lib/Makefile > head/share/mk/bsd.libnames.mk > > Modified: head/ObsoleteFiles.inc > ============================================================================== > --- head/ObsoleteFiles.inc Sun Dec 30 15:38:06 2012 (r244864) > +++ head/ObsoleteFiles.inc Sun Dec 30 16:28:06 2012 (r244865) > @@ -38,6 +38,9 @@ > # xargs -n1 | sort | uniq -d; > # done > > +# 20121230: libdisk removed > +OLD_FILES+=usr/share/man/man3/libdisk.3.gz usr/include/libdisk.h > +OLD_FILES+=usr/lib/libdisk.a usr/lib32/libdisk.a > # 20121230: remove wrongly created directories for auditdistd > OLD_DIRS+=var/dist > OLD_DIRS+=var/remote > > Modified: head/lib/Makefile > ============================================================================== > --- head/lib/Makefile Sun Dec 30 15:38:06 2012 (r244864) > +++ head/lib/Makefile Sun Dec 30 16:28:06 2012 (r244865) > @@ -69,7 +69,6 @@ SUBDIR= ${SUBDIR_ORDERED} \ > libcompat \ > libdevinfo \ > libdevstat \ > - libdisk \ > libdwarf \ > libedit \ > ${_libefi} \ > > Modified: head/share/mk/bsd.libnames.mk > ============================================================================== > --- head/share/mk/bsd.libnames.mk Sun Dec 30 15:38:06 2012 (r244864) > +++ head/share/mk/bsd.libnames.mk Sun Dec 30 16:28:06 2012 (r244865) > @@ -45,7 +45,6 @@ LIBCURSES?= ${DESTDIR}${LIBDIR}/libcurse > LIBDEVINFO?= ${DESTDIR}${LIBDIR}/libdevinfo.a > LIBDEVSTAT?= ${DESTDIR}${LIBDIR}/libdevstat.a > LIBDIALOG?= ${DESTDIR}${LIBDIR}/libdialog.a > -LIBDISK?= ${DESTDIR}${LIBDIR}/libdisk.a > LIBDNS?= ${DESTDIR}${LIBDIR}/libdns.a > LIBDTRACE?= ${DESTDIR}${LIBDIR}/libdtrace.a > LIBDWARF?= ${DESTDIR}${LIBDIR}/libdwarf.a > @@ -54,7 +53,6 @@ LIBELF?= ${DESTDIR}${LIBDIR}/libelf.a > LIBFETCH?= ${DESTDIR}${LIBDIR}/libfetch.a > LIBFL?= "don't use LIBFL, use LIBL" > LIBFORM?= ${DESTDIR}${LIBDIR}/libform.a > -LIBFTPIO?= ${DESTDIR}${LIBDIR}/libftpio.a > LIBG2C?= ${DESTDIR}${LIBDIR}/libg2c.a > LIBGCC?= ${DESTDIR}${LIBDIR}/libgcc.a > LIBGCC_PIC?= ${DESTDIR}${LIBDIR}/libgcc_pic.a