From owner-freebsd-acpi@FreeBSD.ORG  Wed Jun 23 21:13:15 2004
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D1EB016A4CE
	for <acpi@FreeBSD.ORG>; Wed, 23 Jun 2004 21:13:15 +0000 (GMT)
Received: from harmony.village.org (rover.village.org [168.103.84.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 45D8143D2F
	for <acpi@FreeBSD.ORG>; Wed, 23 Jun 2004 21:13:15 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (warner@rover2.village.org [10.0.0.1])
	by harmony.village.org (8.12.11/8.12.11) with ESMTP id i5NLAvXd092869;
	Wed, 23 Jun 2004 15:10:58 -0600 (MDT)
	(envelope-from imp@bsdimp.com)
Date: Wed, 23 Jun 2004 15:11:07 -0600 (MDT)
Message-Id: <20040623.151107.13281033.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20040623135554.V87272@root.org>
References: <20040623123827.O86825@root.org>
	<20000623205805.4c299e4e.liamfoy@sepulcrum.org>
	<20040623135554.V87272@root.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: acpi@FreeBSD.ORG
Subject: Re: apm problem
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jun 2004 21:13:15 -0000

In message: <20040623135554.V87272@root.org>
            Nate Lawson <nate@root.org> writes:
: On Fri, 23 Jun 2000, Liam J. Foy wrote:
: > On Wed, 23 Jun 2004 12:40:40 -0700 (PDT)
: > We decided to go with -1. The apm.c patch currently will not apply due to
: > the re-structure of apm. The following patch will:
: >
: > http://liamfoy.kerneled.org/apm.diff
: 
: Ok, good.  That should help Warner.
: 
: > After more digging, apm -l should return 255(stated in man page and acpi spec).
: > The following patch will make it work:
: >
: > --- /usr/src/sys/dev/acpica/acpi_cmbat.c	Tue Jun 22 16:40:35 2004
: > +++ /hd2/acpi_cmbat.c	Tue Jun 22 17:02:18 2004
: > @@ -449,7 +449,7 @@
: >      static int	bat_units = 0;
: >      static struct acpi_cmbat_softc **bat = NULL;
: >
: > -    cap = min = -1;
: > +    cap = min = 255;
: >      batt_stat = ACPI_BATT_STAT_NOT_PRESENT;
: >      error = 0;
: >
: > @@ -545,7 +545,7 @@
: >
: >      /* Battery life */
: >      if (valid_units == 0) {
: > -	cap = -1;
: > +	cap = 255;
: >  	batt_stat = ACPI_BATT_STAT_NOT_PRESENT;
: >      } else {
: >  	cap = total_cap / valid_units;
: > @@ -649,7 +649,7 @@
: >      }
: >
: >      if (!sc->present) {
: > -	battinfo->cap = -1;
: > +	battinfo->cap = 255;
: >  	battinfo->min = -1;
: >  	battinfo->state = ACPI_BATT_STAT_NOT_PRESENT;
: >      } else {
: 
: I disagree with this.  Capacity and time remaining are both quantities
: represented by ints that we calculate.  The man page should be updated if
: it's incorrect.

That's why I've been reluctant to make these changes...

Warner