From owner-svn-src-projects@FreeBSD.ORG Sat Jan 9 23:02:49 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F300D1065670; Sat, 9 Jan 2010 23:02:49 +0000 (UTC) (envelope-from brooks@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id C8A598FC08; Sat, 9 Jan 2010 23:02:49 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o09N2nbx041784; Sat, 9 Jan 2010 23:02:49 GMT (envelope-from brooks@svn.freebsd.org) Received: (from brooks@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o09N2nEq041780; Sat, 9 Jan 2010 23:02:49 GMT (envelope-from brooks@svn.freebsd.org) Message-Id: <201001092302.o09N2nEq041780@svn.freebsd.org> From: Brooks Davis Date: Sat, 9 Jan 2010 23:02:49 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r201944 - in projects/ngroups/sys: fs/procfs kern sys X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2010 23:02:50 -0000 Author: brooks Date: Sat Jan 9 23:02:49 2010 New Revision: 201944 URL: http://svn.freebsd.org/changeset/base/201944 Log: Improve a few comments. Modified: projects/ngroups/sys/fs/procfs/procfs_status.c projects/ngroups/sys/kern/subr_param.c projects/ngroups/sys/sys/socket.h Modified: projects/ngroups/sys/fs/procfs/procfs_status.c ============================================================================== --- projects/ngroups/sys/fs/procfs/procfs_status.c Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/fs/procfs/procfs_status.c Sat Jan 9 23:02:49 2010 (r201944) @@ -82,7 +82,7 @@ procfs_doprocstatus(PFS_FILL_ARGS) sid = sess->s_leader ? sess->s_leader->p_pid : 0; /* comm pid ppid pgid sid tty ctty,sldr start ut st wmsg - euid ruid rgid,egid,groups[1 ...] + euid ruid rgid,egid,groups[1 .. ngroups] */ pc = p->p_comm; Modified: projects/ngroups/sys/kern/subr_param.c ============================================================================== --- projects/ngroups/sys/kern/subr_param.c Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/kern/subr_param.c Sat Jan 9 23:02:49 2010 (r201944) @@ -231,8 +231,8 @@ init_param1(void) TUNABLE_ULONG_FETCH("kern.sgrowsiz", &sgrowsiz); /* - * Let the user set ngroups_max, but don't let it go below - * NGROUPS_MAX which would violate POSIX.1-2008. + * Let the administrator set {NGROUPS_MAX}, but disallow values + * less than NGROUPS_MAX which would violate POSIX.1-2008. */ ngroups_max = NGROUPS_MAX; TUNABLE_INT_FETCH("kern.ngroups", &ngroups_max); Modified: projects/ngroups/sys/sys/socket.h ============================================================================== --- projects/ngroups/sys/sys/socket.h Sat Jan 9 23:02:14 2010 (r201943) +++ projects/ngroups/sys/sys/socket.h Sat Jan 9 23:02:49 2010 (r201944) @@ -462,7 +462,8 @@ struct cmsghdr { #if __BSD_VISIBLE /* * While we may have more groups than this, the cmsgcred struct must - * be able to fit in an mbuf. + * be able to fit in an mbuf and we have historically supported a + * maximum of 16 groups. */ #define CMGROUP_MAX 16