From owner-freebsd-stable@FreeBSD.ORG Sun Oct 12 10:40:37 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 312F31065697; Sun, 12 Oct 2008 10:40:37 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 06F228FC1B; Sun, 12 Oct 2008 10:40:37 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [65.122.17.41]) by cyrus.watson.org (Postfix) with ESMTP id AB2FB46B09; Sun, 12 Oct 2008 06:40:36 -0400 (EDT) Date: Sun, 12 Oct 2008 11:40:36 +0100 (BST) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Vlad GALU In-Reply-To: Message-ID: References: <200810101458.m9AEw2KI082581@lava.sentex.ca> <20081010152116.GA35404@icarus.home.lan> <20081010154404.GA36021@icarus.home.lan> User-Agent: Alpine 1.10 (BSF 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Jeremy Chadwick , freebsd-stable@freebsd.org Subject: Re: UDP LOR with the latest RELENG_7 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2008 10:40:37 -0000 On Fri, 10 Oct 2008, Robert Watson wrote: > On Fri, 10 Oct 2008, Jeremy Chadwick wrote: > >>> I'll see whether the system still locks up or not though.. >> >> Okay, I'm bringing rwatson@ into the thread since this is specific to UDP. > > I've now fixed the bug leading to the lock order reversal; I'd be interested > in knowing if it also corrects the stability issue. This was r183753 in > svn; I'm not sure it's hit CVS/cvsup yet but should do in a few minutes. Dear Vlad: Could you confirm that with udp_usrreq.c:1.218.2.7 (or newer), the problem has gone away? CVS log excerpt below. Thanks, Robert N M Watson Computer Laboratory University of Cambridge revision 1.218.2.7 date: 2008/10/10 21:18:12; author: rwatson; state: Exp; lines: +8 -8 SVN rev 183753 on 2008-10-10 21:18:12Z by rwatson Test the soreceive_dgram tunable and set up the pr_usrreqs structure during UDP initialization, not during UDP inpcb initialization. Reported by: Vlad GALU Approved by: re (kib)