From owner-svn-src-head@FreeBSD.ORG Sun Nov 2 00:09:34 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0F81DB00; Sun, 2 Nov 2014 00:09:34 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id BD4E9986; Sun, 2 Nov 2014 00:09:33 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id 5BFD4A606; Sun, 2 Nov 2014 00:09:32 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id CE07710AC9; Sun, 2 Nov 2014 01:09:34 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Ian Lepore Subject: Re: svn commit: r273872 - in head: etc/defaults etc/rc.d libexec/save-entropy share/examples/kld/random_adaptor sys/conf sys/dev/glxsb sys/dev/random sys/kern sys/modules sys/modules/padlock_rng sys/mo... References: <201410302121.s9ULLsEw055630@svn.freebsd.org> <20141101181536.2b6a5911@kan> <627C5F71-939A-4579-8A1B-45933662DAED@FreeBSD.org> <1414882185.17308.221.camel@revolution.hippie.lan> <86r3xm5wt6.fsf@nine.des.no> <86mw8a5we0.fsf@nine.des.no> <1414885448.17308.236.camel@revolution.hippie.lan> Date: Sun, 02 Nov 2014 01:09:34 +0100 In-Reply-To: <1414885448.17308.236.camel@revolution.hippie.lan> (Ian Lepore's message of "Sat, 01 Nov 2014 17:44:08 -0600") Message-ID: <86egtm5upt.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Adrian Chadd , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Mark R V Murray , Alexander Kabaev X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2014 00:09:34 -0000 Ian Lepore writes: > Yeah. I vaguely remember discussion about this something like 12-18 > months ago. As I remember it, there was a desire to avoid using the > same startup saved entropy on a rapid series of reboots and the thinking > was to combat that by generating some fresh saved entropy on each boot. Sure, but this can be done from cron instead of an rc script (see below). > It seems like that should work if the old saved entropy were stirred > in with the modicum of boot-time entropy before generating a new save > file. That's what happens in random_start(). > I was thinking maybe postrandom should only try to save a new file if > there are some existing files to avoid the possibility of hanging. But > when I look at postrandom more closely, it seems to be generating a save > file, then deleting it along with all the other save files. Umm, yes, I hadn't noticed that (I only reviewed the kernel code). I think we should just remove the fastsaveseed line. Instead, make a @reboot entry for save-entropy in /etc/crontab. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no