From owner-freebsd-arch@FreeBSD.ORG Mon Jan 9 06:27:07 2012 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DAE94106564A; Mon, 9 Jan 2012 06:27:07 +0000 (UTC) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id CAE0E8FC08; Mon, 9 Jan 2012 06:27:07 +0000 (UTC) Received: by elvis.mu.org (Postfix, from userid 1192) id 8ECF01A3C6D; Sun, 8 Jan 2012 22:17:06 -0800 (PST) Date: Sun, 8 Jan 2012 22:17:06 -0800 From: Alfred Perlstein To: Don Lewis Message-ID: <20120109061706.GC89781@elvis.mu.org> References: <201201082035.q08KZjL5024434@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201201082035.q08KZjL5024434@gw.catspoiler.org> User-Agent: Mutt/1.4.2.3i Cc: arch@FreeBSD.org Subject: Re: [patch] allow crash dumps to Linux swap partitions X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2012 06:27:07 -0000 This is cool, it does seem to beg for a function instead of inlining the logic in two places in case someone wants to add even more logic to it. * Don Lewis [120108 13:14] wrote: > I've got a machine that is set up to dual boot both FreeBSD and Linux. > It is also disk space impaired, so to make the best use possible of the > available space, I have FreeBSD set up to swap to the Linux swap > partition. Until now I haven't had working crash dumps because geom > didn't permit crash dumps to Linux swap partitions. This patch removes > that limitation. This could be useful for users of laptops who boot > multiple operating systems. > > > Index: sys/geom/part/g_part_ebr.c > =================================================================== > --- sys/geom/part/g_part_ebr.c (revision 229800) > +++ sys/geom/part/g_part_ebr.c (working copy) > @@ -333,9 +333,10 @@ > { > struct g_part_ebr_entry *entry; > > - /* Allow dumping to a FreeBSD partition only. */ > + /* Allow dumping to a FreeBSD partition or Linux swap partition only. */ > entry = (struct g_part_ebr_entry *)baseentry; > - return ((entry->ent.dp_typ == DOSPTYP_386BSD) ? 1 : 0); > + return ((entry->ent.dp_typ == DOSPTYP_386BSD || > + entry->ent.dp_typ == DOSPTYP_LINSWP) ? 1 : 0); > } > > #if defined(GEOM_PART_EBR_COMPAT) > Index: sys/geom/part/g_part_mbr.c > =================================================================== > --- sys/geom/part/g_part_mbr.c (revision 229800) > +++ sys/geom/part/g_part_mbr.c (working copy) > @@ -304,9 +304,10 @@ > { > struct g_part_mbr_entry *entry; > > - /* Allow dumping to a FreeBSD partition only. */ > + /* Allow dumping to a FreeBSD partition or Linux swap partition only. */ > entry = (struct g_part_mbr_entry *)baseentry; > - return ((entry->ent.dp_typ == DOSPTYP_386BSD) ? 1 : 0); > + return ((entry->ent.dp_typ == DOSPTYP_386BSD || > + entry->ent.dp_typ == DOSPTYP_LINSWP) ? 1 : 0); > } > > static int > > > > Is anyone else disturbed by the foot shooting potential of allowing > crash dumps to be written to 386BSD partitions? > > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" -- - Alfred Perlstein .- VMOA #5191, 03 vmax, 92 gs500, 85 ch250, 07 zx10 .- FreeBSD committer