From owner-svn-ports-head@freebsd.org Mon Jul 11 12:45:07 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0D2FB91A85; Mon, 11 Jul 2016 12:45:07 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8C9EB1C6C; Mon, 11 Jul 2016 12:45:07 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip70-178-28-115.ks.ks.cox.net [70.178.28.115]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id BDB1A43C3B; Mon, 11 Jul 2016 07:45:04 -0500 (CDT) Subject: Re: svn commit: r418247 - in head/devel/gps: . files To: Alexey Dokuchaev , John Marino References: <201607082228.u68MS4Kf096971@repo.freebsd.org> <20160711122341.GA57651@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org From: John Marino Reply-To: marino@freebsd.org Message-ID: Date: Mon, 11 Jul 2016 07:45:01 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160711122341.GA57651@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 160711-0, 07/11/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 12:45:07 -0000 On 7/11/2016 07:23, Alexey Dokuchaev wrote: > On Fri, Jul 08, 2016 at 10:28:04PM +0000, John Marino wrote: >> New Revision: 418247 >> URL: https://svnweb.freebsd.org/changeset/ports/418247 >> >> Log: >> devel/gps: Fix compiler error highlight on FreeBSD >> >> On DragonFly, GPS has been properly highlighting code errors during >> compilation, but on FreeBSD nothing happens. Luckily Rod Kay has been >> persistent in diagnosing the cause and he finally isolated it to a >> too-short timeout interval for Expect calls. The timeout period was >> set to 1 millisecond, the absolute shortest interval possible. While >> Linux and DF could complete the function call during this time, FreeBSD >> requires at least 10 milliseconds to do the same. > > Fascinating. Did you guys try to understand what makes Linux and DF over a > magnitude faster than FreeBSD? Is there something that needs to be fixed? > I didn't spend much time on it because it's nothing that can be fixed with regard to GPS. I believe the timeout of "1" is itself a logic mistake that FreeBSD exposed. With a cursory glance, I'd guess the problem is centered around polling file descriptors -- I'd particularly suspect the __gnat_expect_poll function in gcc/ada/expect.c to hold the answer. short answer: yes, the implementation of the culprit should be improved at the OS-level but you are talking about FreeBSD 12. I wrote this descriptive commit in the hopes it would catch someone's eye. John --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus