Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 5 Nov 2002 12:30:36 -0800
From:      Marcel Moolenaar <marcel@xcllnt.net>
To:        Maxime Henrion <mux@freebsd.org>
Cc:        Juli Mallett <jmallett@freebsd.org>, Patrick Hartling <patrick@137.org>, current@freebsd.org
Subject:   Re: uuid.h is not C++ safe
Message-ID:  <20021105123036.A99916@kayak.xcllnt.net>
In-Reply-To: <20021105111724.GF26605@elvis.mu.org>
References:  <3DC71B56.1050102@137.org> <20021105105813.GD26605@elvis.mu.org> <20021105105927.GE26605@elvis.mu.org> <20021105030419.A19427@FreeBSD.org> <20021105111724.GF26605@elvis.mu.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 05, 2002 at 03:17:24AM -0800, Maxime Henrion wrote:
> Juli Mallett wrote:
> > * De: Maxime Henrion <mux@freebsd.org> [ Data: 2002-11-05 ]
> > 	[ Subjecte: Re: uuid.h is not C++ safe ]
> > > Maxime Henrion wrote:
> > > > Patrick Hartling wrote:
> > > > > I was just about to put the new DCE 1.1 UUID functions into use in some 
> > > > > C++ code, but linking fails because the function prototypes in uuid.h 
> > > > > are not protected with the __cplusplus/extern "C" bits.  It's easy 
> > > > > enough for me to fix my local copy, but I'm sure this same thing could 
> > > > > trip up other people.
> > > > 
> > > > This should be fixed with the attached patch.  Marcel, can you review
> > > > and commit it please ?
> > 
> > Oops, I probably should have pinged Marcel about this, now that I think
> > about it, but anyway, it shouldn't change anything.  Even with vanilla
> > cpp(1) both produce the right thing, with or without __cplusplus defined,
> > and both produce the identical thing (moins linenos/whitespace) in the
> > C case.
> > 
> > Of course, both <uuid.h> and <sys/uuid.h> needed changed, as both
> > define protos, and <sys/uuid.h> is included into <uuid.h>.
> 
> That's arguably bad, sys/uuid.h shouldn't have any !_KERNEL prototypes
> in it.

If there's a better place, then we should move it. We could put it in
<uuid.h>, but I don't want to make that header a requirement if one
only uses the syscall. I don't yet know what a good place would be,
if not <sys/uuid.h>. Suggestions?

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021105123036.A99916>