From owner-cvs-all@FreeBSD.ORG Sun Oct 22 02:07:19 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D6EA16A412; Sun, 22 Oct 2006 02:07:19 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id C56A143D46; Sun, 22 Oct 2006 02:07:18 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id A86F21A3C1C; Sat, 21 Oct 2006 19:07:18 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 04B7751595; Sat, 21 Oct 2006 22:07:16 -0400 (EDT) Date: Sat, 21 Oct 2006 22:07:16 -0400 From: Kris Kennaway To: Don Lewis Message-ID: <20061022020716.GA29912@xor.obsecurity.org> References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610220014.k9M0E5mG061752@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DocE+STaALJfprDB" Content-Disposition: inline In-Reply-To: <200610220014.k9M0E5mG061752@gw.catspoiler.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, davidxu@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Oct 2006 02:07:19 -0000 --DocE+STaALJfprDB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 21, 2006 at 05:14:05PM -0700, Don Lewis wrote: > On 21 Oct, David Xu wrote: > > davidxu 2006-10-21 23:59:15 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern kern_exit.c=20 > > Log: > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > opened a race window which can cause memory leak in signal queue. > > Here we free memory for signal queue when process state is set to > > PRS_ZOMBIE. > > =20 > > Revision Changes Path > > 1.291 +8 -2 src/sys/kern/kern_exit.c >=20 > I wonder if the earlier change is what broke portupgrade after I > upgraded from an August 31st version of current to yesterday's version. > The symptoms were random processes dying from SIGHUP. It was easy to > reproduce by just going to a port directory and running > script foo make clean > a few times. I'd randomly see make complain about a non-zero exit > status from uname or some other sub-process. I tracked the problem back > to the SIGHUP bit being set in td2's sigqueue in fork1(). As a > workaround, I added a call to sigqueue_init() where td2 gets bzero'ed. Something is making java segfault reproducibly on a recent kernel too. I'll test to see whether this fixes it. Kris --DocE+STaALJfprDB Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFOtJUWry0BWjoQKURAoaMAKDsl/UFHao/r6WjlWkK+WhQyWagQACeLLIu 5E8YovHpQFbvrUj/tO1fyxM= =gu5c -----END PGP SIGNATURE----- --DocE+STaALJfprDB--