From owner-svn-src-head@FreeBSD.ORG Mon Oct 27 19:21:51 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A0D510656AF; Mon, 27 Oct 2008 19:21:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id B91618FC0C; Mon, 27 Oct 2008 19:21:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id m9RJLJMS014395; Mon, 27 Oct 2008 15:21:42 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Sam Leffler Date: Mon, 27 Oct 2008 14:28:02 -0400 User-Agent: KMail/1.9.7 References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com> <4901F173.2070701@freebsd.org> In-Reply-To: <4901F173.2070701@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200810271428.03345.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 27 Oct 2008 15:21:42 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8511/Mon Oct 27 14:23:52 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, marcel@freebsd.org, src-committers@freebsd.org, Warner Losh Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2008 19:21:51 -0000 On Friday 24 October 2008 12:01:55 pm Sam Leffler wrote: > Warner Losh wrote: > > From: Marcel Moolenaar > > Subject: svn commit: r184193 - in head/sys: arm/conf conf > > Date: Thu, 23 Oct 2008 01:51:55 +0000 (UTC) > > > > > >> Author: marcel > >> Date: Thu Oct 23 01:51:55 2008 > >> New Revision: 184193 > >> URL: http://svn.freebsd.org/changeset/base/184193 > >> > >> Log: > >> Add arm/conf/DEFAULTS and populate it with: > >> machine arm > >> device mem > >> options GEOM_BSD > >> options GEOM_MBR > >> > >> Remove the first two from all kernel configuration files and > >> change geom_bsd and geom_mbr from standard to optional. > >> > >> Added: > >> head/sys/arm/conf/DEFAULTS (contents, props changed) > >> > > > > We already have a better mechanism for including config files. We > > should be using that instead of poluting another port with the > > DEFAULTS file. > > > More importantly this change forces GEOM_BSD and GEOM_MBR on every > target platform. This is just wrong and clearly Marvel never discussed > it with anyone working on arm systems or he'd have gotten an earful. > > Marcel, please back this stuff out. Sam, I have to say that if you look at what Marcel did, he actually helped your cause. Previously, any ARM kernel you built _always_ had GEOM_BSD and GEOM_MBR in unless you hacked sys/conf/files.arm. Now you can just put 'nooptions GEOM_BSD' or 'nooptions GEOM_MBR' in your kernel config to remove them without having to hack sys/conf/files.arm. This is a step forward, not a step backwards. Of course, you are always free to add explicit GEOM_MBR/GEOM_BSD lines to the ARM configs that need it and then remove them from DEFAULTS. But this change 1) preserves people's existing kernel configs to still do the same thing as before and 2) introduces the _new_ ability to turn off GEOM_MBR/GEOM_BSD that _wasn't_ _there_ _before_ without local hacks. -- John Baldwin