From owner-svn-src-head@freebsd.org Mon Sep 16 07:08:08 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2EDADF604B; Mon, 16 Sep 2019 07:08:08 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46Wy4m0QcSz4FSs; Mon, 16 Sep 2019 07:08:08 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: from ivaldir.etoilebsd.net (etoilebsd.net [178.32.217.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id CDB6E973D; Mon, 16 Sep 2019 07:08:07 +0000 (UTC) (envelope-from bapt@FreeBSD.org) Received: by ivaldir.etoilebsd.net (Postfix, from userid 1001) id 3EDB6B704C; Mon, 16 Sep 2019 09:08:06 +0200 (CEST) Date: Mon, 16 Sep 2019 09:08:06 +0200 From: Baptiste Daroussin To: Dimitry Andric Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352341 - head/contrib/libedit Message-ID: <20190916070805.ykasrsmqdol3jwqt@ivaldir.net> References: <201909142149.x8ELnhqE035300@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zzllgpaayqdv4sjx" Content-Disposition: inline In-Reply-To: <201909142149.x8ELnhqE035300@repo.freebsd.org> User-Agent: NeoMutt/20180716 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 07:08:08 -0000 --zzllgpaayqdv4sjx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 14, 2019 at 09:49:43PM +0000, Dimitry Andric wrote: > Author: dim > Date: Sat Sep 14 21:49:42 2019 > New Revision: 352341 > URL: https://svnweb.freebsd.org/changeset/base/352341 >=20 > Log: > Fix arm and aarch64 builds of libedit after r352275 > =20 > On arm and arm64, where chars are unsigned by default, buildworld dies > with: > =20 > --- terminal.o --- > /usr/src/contrib/libedit/terminal.c:569:41: error: comparison of > integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka > 'unsigned int') [-Werror,-Wsign-compare] > el->el_cursor.v][where & 0370] !=3D > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ > /usr/src/contrib/libedit/terminal.c:659:28: error: comparison of > integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka > 'unsigned int') [-Werror,-Wsign-compare] > [el->el_cursor.h] =3D=3D MB_FILL_C= HAR) > ~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~ > =20 > Fix this by making MB_FILL_CHAR a wint_t, so no casting is needed. > =20 > Note that in https://reviews.freebsd.org/D21584 this was also proposed > by Yuichiro Naito . > =20 > Reviewed by: bapt > Subscribers: naito.yuichiro_gmail.com, ml_vishwin.info > MFC after: 3 weeks > X-MFC-With: r352275 > Differential Revision: https://reviews.freebsd.org/D21657 >=20 Just for completeness it was also approved by christos@NetBSD (upstream) --zzllgpaayqdv4sjx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAl1/NNMACgkQY4mL3PG3 PlrTaBAAtSpZxpx+klDe7Ic8UnmaYCPlu2pp4JVx55Zo5INSHmJBFnIKn38NZkjo KmnaQafSQVePFhyO93ZO6tLkb7rwsfvhwDVzkEHzvfLHlk5qeTDD57zH0nmhS/T2 MeXthJsKck3HP3BCA2v5LCEFXcjB1TiLRNG5v+/8897XbZPv7388xusHTMRjRKMW 111DVTfeiMFqFp2iFqXF+gcH0xEQy3dNv4cI+CBoHza2kD82r3jyt+K4KvhcdO79 VkWDX0yaQw0Hx99sZkP7DWywiAHHRS9tg7vDzPYZ5kYP1qqujkEqF0wAvc4mW8e3 sryAHrkX23PhBVqvhjIWHKxzbIVFzpTVxntbBIlPJo728e/7zOIVljqOH6V/PCRC w48un16RmsxfHzNTSuFa3NKkDTBDfxhDRMPzWOED00+X3dZvgUTJQbtyk9DyA8wd IDvsjcZ3bkZDtEZhJB7jwrMHd6QBeo3cvGXwQEjuJMAdDHXurrCpEaIDzLTHI71U Rrk0I0pd6r0f5zyE/dA9pMVLF5e5w8idMk4smPVzpBBgFRy6TtAq/i/60IqvTeAf cUs1bFimAJqc8Q+DQgLZvBEDO7R0JiD0v8I0EDtXaOJiwILQwWfqgNrpJCoRkRcp gEg0WiwsG3XOe9zkyuXBm9yCYb3VixVhZaCugc5j1P5i/0m+Xmk= =9ch+ -----END PGP SIGNATURE----- --zzllgpaayqdv4sjx--