From nobody Fri Nov 10 11:53:48 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SRcfj0Kkkz50R7x for ; Fri, 10 Nov 2023 11:53:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SRcfh6LCcz3dt3 for ; Fri, 10 Nov 2023 11:53:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1699617228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ns+vg9a82fr9Jf5LbUsmG936/ITiZpUMUqWW9dYl/Do=; b=mrqPkEBF5gf3IBBdoPgJgcZKd8Na8WCmxMENF74phw2uIXIqahTvBI+sYWva11emGtQpb0 fiw+LX5oD+5aD2WKhQmhi3AAhNeWpk9XuSYZGPhkTSg8WSaOruIidJapWqF7JreN9x/qBe eO//oujQ5Fpr5IKg45HjqTt4wQOVe8tUn4myBTKCCEaKxoaTh4LgfZ13dQLJ3iXCOwVR+E mbVQjrQ+G6JsP53pdcnlKXfa6oOo2Av/UVefYjNKH86LJhq716wI9T4mP63d7e3aLb15GI T/spVSFHHKHPdrnUMdcSIHa6ljeAU2+BPWEgCg8RwOfV2FNds8YSyOsOCBCIuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1699617228; a=rsa-sha256; cv=none; b=s8d33+52gcYTXKzUlzpEaTBcoucVPEag4JNS1lK2R18fasHGm98+hMZBQefX/y1l9rqYrf R8yxL9q+OWHVJJEbbgfwaiwo9qRaGMXdV0uA5K1q4pjldP8NuETJ46fw+0nPDq2R8deQyT k8dUkg5F+LcUjrjozrYCZ0DuuELNUFvHkJvNPLjyVvXT3/RolqSFb4zurqa5TSWxARNo0R zuwX6cJHVYIHQfmwhcZQro8qdiG/iA35kipXMW1rvRS6Jb+Q6EUb8Vn14POIH4AHfM9H5C KViGGrgtXmcvY+a8aFoX/tiFtyFHIFIB/q8dNvSyAWzPoAs0To3+8bC1JiU6Vg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SRcfh5Q8kzxDk for ; Fri, 10 Nov 2023 11:53:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AABrmBd061165 for ; Fri, 10 Nov 2023 11:53:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AABrmh7061164 for bugs@FreeBSD.org; Fri, 10 Nov 2023 11:53:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 275006] libpfctl: c2e7cbe0edb backport broke label set on rule Date: Fri, 10 Nov 2023 11:53:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 13.2-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275006 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch stable/13 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D83dbbe8295ff0bb06a8f6b621c25d8224= b026b77 commit 83dbbe8295ff0bb06a8f6b621c25d8224b026b77 Author: Franco Fichtner AuthorDate: 2023-11-10 11:42:17 +0000 Commit: Kristof Provost CommitDate: 2023-11-10 11:47:44 +0000 libpfctl: fix label setting A mismerge caused the labels list to be added to the wrong nvlist, breaking label configuration. If you compare the change from from main and stable/13 you can see that main uses "nvl" and stable/13 has "nlvr" for nvlist_append_string_array() but the backport changes it to "nlv". This code was supposed to apply to pfctl_add_eth_rule() but instead applied to pfctl_add_rule() for otherwise interesting reasons. Since pfctl_add_eth_rule() uses "nvl" and pfctl_add_rule() uses "nvlr" but also has "nvl" this compiled fine but still broke the label set. Direct commit to stable/13. PR: 275006 lib/libpfctl/libpfctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=