From owner-freebsd-hackers Tue Aug 24 15:54:46 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from ryan.org (kenny.inetu.net [206.245.142.2]) by hub.freebsd.org (Postfix) with ESMTP id 7E37D1525D for ; Tue, 24 Aug 1999 15:54:43 -0700 (PDT) (envelope-from ryan@ryan.org) Received: from localhost (ryan@localhost) by ryan.org (8.8.7/8.8.7) with SMTP id RAA07037 for ; Tue, 24 Aug 1999 17:46:40 -0400 (EDT) (envelope-from ryan@ryan.org) Date: Tue, 24 Aug 1999 17:46:40 -0400 (EDT) From: Ryan To: hackers@freebsd.org Subject: Are certain parts of kernel not using suser() when they should? Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Grepping through the kernel source tree, one finds these 12 files that use "uid == 0" checks instead of the usual suser(). There may be more than one instance per function/macro: ./kern/kern_ktrace.c - ktrops(), ktrcanset() ./nfs/nfs_subs.c - nfsrv_fhtoup() ./posix4/p1003_1b.c - CAN_AFFECT macro ./kern/kern_sig.c - CANSIGNAL, CANSIGIO macros ./kern/sysv_ipc.c - ipcperm() ./miscfs/devfs/devfs_vnops.c - devfs_setattr() ./isofs/cd9660/cd9660_vnops.c - cd9660_access() ./miscfs/kernfs/kernfs_vnops.c - kernfs_access() ./miscfs/procfs/procfs_vnops.c - procfs_access() ./msdosfs/msdosfs_vnops.c - msdosfs_access() ./nfs/nfs_vnops.c - nfsspec_access(), nfs_access() ./ufs/ufs/ufs_vnops.c - ufs_access() Is there a reason for these checks not to use suser? -Ryan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message