From owner-svn-src-all@freebsd.org  Tue Jun 28 18:28:40 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1284B8595C;
 Tue, 28 Jun 2016 18:28:40 +0000 (UTC) (envelope-from ken@kdm.org)
Received: from mithlond.kdm.org (mithlond.kdm.org [96.89.93.250])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "A1-33714", Issuer "A1-33714" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 88DAB2C38;
 Tue, 28 Jun 2016 18:28:40 +0000 (UTC) (envelope-from ken@kdm.org)
Received: from mithlond.kdm.org (localhost [127.0.0.1])
 by mithlond.kdm.org (8.15.2/8.14.9) with ESMTPS id u5SIScY0016434
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 28 Jun 2016 14:28:38 -0400 (EDT)
 (envelope-from ken@mithlond.kdm.org)
Received: (from ken@localhost)
 by mithlond.kdm.org (8.15.2/8.14.9/Submit) id u5SISc5L016433;
 Tue, 28 Jun 2016 14:28:38 -0400 (EDT) (envelope-from ken)
Date: Tue, 28 Jun 2016 14:28:38 -0400
From: "Kenneth D. Merry" <ken@FreeBSD.ORG>
To: Sean Bruno <sbruno@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org, re@freebsd.org
Subject: Re: svn commit: r302253 - head/sys/cam/scsi
Message-ID: <20160628182838.GA16229@mithlond.kdm.org>
References: <201606281808.u5SI8l7h091906@repo.freebsd.org>
 <71476326-3FAC-4E49-884F-0A2F38177D99@kdm.org>
 <46721328-61de-e78b-b627-42b06c63e156@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <46721328-61de-e78b-b627-42b06c63e156@freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3
 (mithlond.kdm.org [127.0.0.1]); Tue, 28 Jun 2016 14:28:38 -0400 (EDT)
X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 HEADER_FROM_DIFFERENT_DOMAINS autolearn=ham autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mithlond.kdm.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Jun 2016 18:28:40 -0000

On Tue, Jun 28, 2016 at 11:27:25 -0700, Sean Bruno wrote:
> 
> 
> On 06/28/16 11:17, Ken Merry wrote:
> > This is incorrect.  It should be scsi_ulto4b() instead.
> > 
> > The dxfer_len argument to scsi_persistent_reserve_out() is a uint32_t, and the length field in the CDB structure is 4 bytes long.
> > 
> > Sorry I didn???t get around to commenting on the PR, otherwise I would have caught this previously.
> > 
> > Ken
> > ??? 
> > Ken Merry
> > ken@FreeBSD.ORG
> 
> Ok, I shall revert this then generate a new diff for your review and
> submission to re for commit.

Thanks!

Ken
-- 
Kenneth Merry
ken@FreeBSD.ORG