Date: Tue, 28 Jun 2016 14:28:38 -0400 From: "Kenneth D. Merry" <ken@FreeBSD.ORG> To: Sean Bruno <sbruno@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, re@freebsd.org Subject: Re: svn commit: r302253 - head/sys/cam/scsi Message-ID: <20160628182838.GA16229@mithlond.kdm.org> In-Reply-To: <46721328-61de-e78b-b627-42b06c63e156@freebsd.org> References: <201606281808.u5SI8l7h091906@repo.freebsd.org> <71476326-3FAC-4E49-884F-0A2F38177D99@kdm.org> <46721328-61de-e78b-b627-42b06c63e156@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jun 28, 2016 at 11:27:25 -0700, Sean Bruno wrote: > > > On 06/28/16 11:17, Ken Merry wrote: > > This is incorrect. It should be scsi_ulto4b() instead. > > > > The dxfer_len argument to scsi_persistent_reserve_out() is a uint32_t, and the length field in the CDB structure is 4 bytes long. > > > > Sorry I didn???t get around to commenting on the PR, otherwise I would have caught this previously. > > > > Ken > > ??? > > Ken Merry > > ken@FreeBSD.ORG > > Ok, I shall revert this then generate a new diff for your review and > submission to re for commit. Thanks! Ken -- Kenneth Merry ken@FreeBSD.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160628182838.GA16229>