From owner-svn-src-head@FreeBSD.ORG Tue Apr 26 11:53:41 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5488106566C; Tue, 26 Apr 2011 11:53:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 371208FC21; Tue, 26 Apr 2011 11:53:40 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p3QBrXHh044755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 26 Apr 2011 14:53:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p3QBrXV1028952; Tue, 26 Apr 2011 14:53:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p3QBrXFp028951; Tue, 26 Apr 2011 14:53:33 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 26 Apr 2011 14:53:33 +0300 From: Kostik Belousov To: Hans Petter Selasky Message-ID: <20110426115333.GP48734@deviant.kiev.zoral.com.ua> References: <201104261139.p3QBduVx020817@svn.freebsd.org> <201104261344.00551.hselasky@c2i.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ct8ez/PVgO98mXV4" Content-Disposition: inline In-Reply-To: <201104261344.00551.hselasky@c2i.net> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r221059 - in head/sys: kern sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2011 11:53:41 -0000 --ct8ez/PVgO98mXV4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 26, 2011 at 01:44:00PM +0200, Hans Petter Selasky wrote: > On Tuesday 26 April 2011 13:39:56 Konstantin Belousov wrote: > > + pending =3D !!callout_stop(&timeout_task->c); >=20 > pending =3D (callout_stop(&timeout_task->c) !=3D 0); >=20 > ? This line is about conversion from a boolean value to {0, 1} value set. If !! construct does not look stylish, then wouldn't we need to go with pending =3D (callout_stop(&timeout_task->c) !=3D 0) ? 1 : 0; instead ? Feel free to adjust whatever variant you prefer and commit it. --ct8ez/PVgO98mXV4 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk22sj0ACgkQC3+MBN1Mb4ggfQCgrvHcDN6+1Y8WuU04AIfPN5oH rxcAn33A6RRjpgu/pRYwVZKSbeNc3H9f =9Eou -----END PGP SIGNATURE----- --ct8ez/PVgO98mXV4--