From owner-svn-src-all@freebsd.org Mon Nov 25 15:23:33 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9DA71B02FD; Mon, 25 Nov 2019 15:23:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47M9m53t5Yz4Y0R; Mon, 25 Nov 2019 15:23:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id xAPFNPDM011044 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 25 Nov 2019 17:23:28 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua xAPFNPDM011044 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id xAPFNPLt011043; Mon, 25 Nov 2019 17:23:25 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 25 Nov 2019 17:23:25 +0200 From: Konstantin Belousov To: Ryan Libby Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r355089 - stable/12/sys/x86/include Message-ID: <20191125152325.GE10580@kib.kiev.ua> References: <201911251418.xAPEItMH087104@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 47M9m53t5Yz4Y0R X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.98 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.991,0]; NEURAL_HAM_LONG(-0.99)[-0.994,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2019 15:23:33 -0000 On Mon, Nov 25, 2019 at 06:58:27AM -0800, Ryan Libby wrote: > On Mon, Nov 25, 2019 at 6:19 AM Konstantin Belousov wrote: > > > > Author: kib > > Date: Mon Nov 25 14:18:55 2019 > > New Revision: 355089 > > URL: https://svnweb.freebsd.org/changeset/base/355089 > > > > Log: > > MFC r355088: > > Limit bus_dma_dmar_set_buswide() definition to kernel only. > > > > Modified: > > stable/12/sys/x86/include/bus_dma.h > > Directory Properties: > > stable/12/ (props changed) > > > > Modified: stable/12/sys/x86/include/bus_dma.h > > ============================================================================== > > --- stable/12/sys/x86/include/bus_dma.h Mon Nov 25 14:16:41 2019 (r355088) > > +++ stable/12/sys/x86/include/bus_dma.h Mon Nov 25 14:18:55 2019 (r355089) > > @@ -179,7 +179,9 @@ _bus_dmamap_complete(bus_dma_tag_t dmat, bus_dmamap_t > > return (tc->impl->map_complete(dmat, map, segs, nsegs, error)); > > } > > > > +#ifdef _KERNEL > > bool bus_dma_dmar_set_buswide(device_t dev); > > +#endif > > > > #endif /* !_X86_BUS_DMA_H_ */ > > > > _______________________________________________ > > svn-src-all@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/svn-src-all > > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" > > No complaint, but incidentally I think this didn't trip in current > because r347836 deleted #include from camdd.c. I see, thank you. I will keep this #ifdef around for some time in HEAD as well. If the revision ever get merged into 12, I remove the braces from both branches.