From owner-svn-src-head@freebsd.org  Mon Aug 29 18:46:06 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 448A1BC335B;
 Mon, 29 Aug 2016 18:46:06 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 123F92A83;
 Mon, 29 Aug 2016 18:46:05 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7TIk50v056852;
 Mon, 29 Aug 2016 18:46:05 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7TIk56j056851;
 Mon, 29 Aug 2016 18:46:05 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201608291846.u7TIk56j056851@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Mon, 29 Aug 2016 18:46:05 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r305011 - head/usr.sbin/newsyslog/tests
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Aug 2016 18:46:06 -0000

Author: ngie
Date: Mon Aug 29 18:46:04 2016
New Revision: 305011
URL: https://svnweb.freebsd.org/changeset/base/305011

Log:
  Expect sub testcases 2-4 in :tests_time_rotate to fail today due to changes
  to newsyslog, etc made in the past month.
  
  The issue is being root-caused as part of the bug noted below. This commit
  will need to be partially reverted once the issue has been found/fixed
  
  PR:		212160
  Reported by:	Jenkins
  Sponsored by:	EMC / Isilon Storage Division

Modified:
  head/usr.sbin/newsyslog/tests/legacy_test.sh

Modified: head/usr.sbin/newsyslog/tests/legacy_test.sh
==============================================================================
--- head/usr.sbin/newsyslog/tests/legacy_test.sh	Mon Aug 29 18:41:06 2016	(r305010)
+++ head/usr.sbin/newsyslog/tests/legacy_test.sh	Mon Aug 29 18:46:04 2016	(r305011)
@@ -20,13 +20,22 @@ begin()
 # End an individual test
 end()
 {
+	local message
+
 	if [ $OK = 1 ]
 	then
-		printf 'ok '
+		message='ok '
 	else
-		printf 'not ok '
+		message='not ok '
+	fi
+
+	message="$message $COUNT - $NAME"
+	if [ -n "$TODO" ]
+	then
+		message="$message # TODO $TODO"
 	fi
-	echo "$COUNT - $NAME"
+
+	echo "$message"
 }
 
 # Make a file that can later be verified
@@ -336,6 +345,9 @@ tests_time_rotate() {
 
 	sleep 1.1
 
+	(
+	TODO="rotate time 2-4 fail today; bug 212160"
+
 	begin "rotate time 2 ${name_postfix}"
 	run_newsyslog ${newsyslog_args}
 	ckfe ${LOGFNAME}
@@ -357,6 +369,7 @@ tests_time_rotate() {
 	ckfe ${LOGFNAME}
 	chkfcnt 3 ${dir}${LOGFNAME}.*${ext}
 	end
+	)
 
 	begin "noaction ${name_postfix}"
 	ofiles=`ls -1 ${dir}${LOGFNAME}.*${ext} | tr -d '\n'`