From owner-freebsd-stable@FreeBSD.ORG Thu Nov 6 14:41:37 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0B35C955; Thu, 6 Nov 2014 14:41:37 +0000 (UTC) Received: from wonkity.com (wonkity.com [67.158.26.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "wonkity.com", Issuer "wonkity.com" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AD95783F; Thu, 6 Nov 2014 14:41:36 +0000 (UTC) Received: from wonkity.com (localhost [127.0.0.1]) by wonkity.com (8.14.9/8.14.9) with ESMTP id sA6EfXpH030011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 6 Nov 2014 07:41:33 -0700 (MST) (envelope-from wblock@wonkity.com) Received: from localhost (wblock@localhost) by wonkity.com (8.14.9/8.14.9/Submit) with ESMTP id sA6EfWps030005; Thu, 6 Nov 2014 07:41:33 -0700 (MST) (envelope-from wblock@wonkity.com) Date: Thu, 6 Nov 2014 07:41:32 -0700 (MST) From: Warren Block To: =?ISO-8859-15?Q?Juan_Ram=F3n_Molina_Menor?= Subject: Re: Status of svnlite(1) in make.conf(5) In-Reply-To: <545B5707.20300@club-internet.fr> Message-ID: References: <545B5707.20300@club-internet.fr> User-Agent: Alpine 2.11 (BSF 23 2013-08-11) MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (wonkity.com [127.0.0.1]); Thu, 06 Nov 2014 07:41:33 -0700 (MST) Content-Type: TEXT/PLAIN; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8BIT X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: freebsd-stable@freebsd.org, freebsd-questions@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 14:41:37 -0000 On Thu, 6 Nov 2014, Juan Ramón Molina Menor wrote: >> On Wed, 5 Nov 2014, Chris H wrote: >> >>> On Wed, 05 Nov 2014 22:25:47 +0100 Juan Ramón Molina Menor >>> wrote >>> >>>> Hi! >>>> >>>> Just curious about what it seems an inconsistency with svnlite(1). The >>>> initial commit (r251886) says that it was included for checking out and >>>> committing source and cites two make.conf(5) knobs: WITH_SVN (to get >>>> "svn" instead of "svnlite") and WITHOUT_SVNLITE (in reality, they are in >>>> src.conf(5)). Nevertheless, the make.conf man page says, in the >>>> SVN_UPDATE section, that no subversion client is included in the base >>>> system, and indeed 'make update' does not work by default. >>>> >>>> Should I open a PR or it is too much nitpicking? >>> I think it would be a good idea. I can say for sure that >>> svnlite(1) comes on, and is installed from the bootonly CD/DVD. >>> I think it's also worth mentioning that the entries are actually >>> targeted to the src.conf(5). >>> You may also want to CC docs at . As I think Warren Block might also >>> be interested. >> >> It's just "doc@", but I'm here also. And agreed, if the information in >> a man page is not correct, it needs to be fixed. > > Can I help somehow? It?s not only the man page which needs a fix, but maybe > also /Makefile.inc1: > https://svnweb.freebsd.org/base/head/Makefile.inc1?revision=273755&view=markup#l122 A PR with patch to fix all the files would be the best. A list of the files to change and changes to be made is probably just as difficult to create, but would also work. From owner-freebsd-stable@FreeBSD.ORG Thu Nov 6 15:04:05 2014 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E3E1CEEE; Thu, 6 Nov 2014 15:04:05 +0000 (UTC) Received: from smtp21.services.sfr.fr (smtp21.services.sfr.fr [93.17.128.1]) by mx1.freebsd.org (Postfix) with ESMTP id 78CBCB00; Thu, 6 Nov 2014 15:04:04 +0000 (UTC) Received: from filter.sfr.fr (localhost [93.8.4.165]) by msfrf2104.sfr.fr (SMTP Server) with ESMTP id 40C2C7000079; Thu, 6 Nov 2014 15:55:10 +0100 (CET) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=listjm@club-internet.fr Received: from [192.168.1.67] (165.4.8.93.rev.sfr.net [93.8.4.165]) by msfrf2104.sfr.fr (SMTP Server) with ESMTP id 147087000066; Thu, 6 Nov 2014 15:55:09 +0100 (CET) X-SFR-UUID: 20141106145509838.147087000066@msfrf2104.sfr.fr Message-ID: <545B8BCB.9040106@club-internet.fr> Date: Thu, 06 Nov 2014 15:55:07 +0100 From: Juan =?iso-8859-1?b?UmFt824=?= Molina Menor User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Warren Block Subject: Re: Status of svnlite(1) in make.conf(5) References: <545B5707.20300@club-internet.fr> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-stable@freebsd.org, freebsd-questions@freebsd.org X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Nov 2014 15:04:06 -0000 El 06/11/2014 15:41, Warren Block escribió: > On Thu, 6 Nov 2014, Juan Ramón Molina Menor wrote: > >>> On Wed, 5 Nov 2014, Chris H wrote: >>> >>>> On Wed, 05 Nov 2014 22:25:47 +0100 Juan Ramón Molina Menor >>>> wrote >>>> >>>>> Hi! >>>>> >>>>> Just curious about what it seems an inconsistency with svnlite(1). The >>>>> initial commit (r251886) says that it was included for checking out >>>>> and >>>>> committing source and cites two make.conf(5) knobs: WITH_SVN (to get >>>>> "svn" instead of "svnlite") and WITHOUT_SVNLITE (in reality, they >>>>> are in >>>>> src.conf(5)). Nevertheless, the make.conf man page says, in the >>>>> SVN_UPDATE section, that no subversion client is included in the base >>>>> system, and indeed 'make update' does not work by default. >>>>> >>>>> Should I open a PR or it is too much nitpicking? >>>> I think it would be a good idea. I can say for sure that >>>> svnlite(1) comes on, and is installed from the bootonly CD/DVD. >>>> I think it's also worth mentioning that the entries are actually >>>> targeted to the src.conf(5). >>>> You may also want to CC docs at . As I think Warren Block might also >>>> be interested. >>> >>> It's just "doc@", but I'm here also. And agreed, if the information in >>> a man page is not correct, it needs to be fixed. >> >> Can I help somehow? It?s not only the man page which needs a fix, but >> maybe also /Makefile.inc1: >> https://svnweb.freebsd.org/base/head/Makefile.inc1?revision=273755&view=markup#l122 >> > > A PR with patch to fix all the files would be the best. A list of the > files to change and changes to be made is probably just as difficult to > create, but would also work. For the man page, I’ll try to find time to follow the "FreeBSD Documentation Project Primer for New Contributors", even if it seems quite daunting. For the make infrastructure, I’m quite sure I won’t be able to fulfil the task, but I’ll try too. Best regards, Juan