From owner-svn-src-head@FreeBSD.ORG  Tue Jul 13 09:17:30 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE36F106567F;
	Tue, 13 Jul 2010 09:17:30 +0000 (UTC)
	(envelope-from lstewart@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id D04388FC1E;
	Tue, 13 Jul 2010 09:17:30 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o6D9HUil079997;
	Tue, 13 Jul 2010 09:17:30 GMT
	(envelope-from lstewart@svn.freebsd.org)
Received: (from lstewart@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o6D9HUb3079995;
	Tue, 13 Jul 2010 09:17:30 GMT
	(envelope-from lstewart@svn.freebsd.org)
Message-Id: <201007130917.o6D9HUb3079995@svn.freebsd.org>
From: Lawrence Stewart <lstewart@FreeBSD.org>
Date: Tue, 13 Jul 2010 09:17:30 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r209987 - head/sys/sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 13 Jul 2010 09:17:31 -0000

Author: lstewart
Date: Tue Jul 13 09:17:30 2010
New Revision: 209987
URL: http://svn.freebsd.org/changeset/base/209987

Log:
  - The sum variable used in DPCPU_SUM needs to be of the same type as the
    DPCPU variable, rather than a pointer to the type.
  
  - Zero # bytes equivalent to sizeof(object), not sizeof(ptr_to_object).
  
  - Remove an unnecessary __typeof.
  
  Sponsored by:	FreeBSD Foundation
  Submitted by:	jmallet
  MFC after:	3 days

Modified:
  head/sys/sys/pcpu.h

Modified: head/sys/sys/pcpu.h
==============================================================================
--- head/sys/sys/pcpu.h	Tue Jul 13 08:55:52 2010	(r209986)
+++ head/sys/sys/pcpu.h	Tue Jul 13 09:17:30 2010	(r209987)
@@ -112,7 +112,7 @@ extern uintptr_t dpcpu_off[];
 #define	DPCPU_SUM(n) __extension__					\
 ({									\
 	u_int _i;							\
-	__typeof(DPCPU_PTR(n)) sum;					\
+	__typeof(*DPCPU_PTR(n)) sum;					\
 									\
 	sum = 0;							\
 	CPU_FOREACH(_i) {						\
@@ -137,8 +137,7 @@ extern uintptr_t dpcpu_off[];
 	u_int _i;							\
 									\
 	CPU_FOREACH(_i) {						\
-		bzero(DPCPU_ID_PTR(_i, n),				\
-		    sizeof(__typeof(DPCPU_PTR(n))));			\
+		bzero(DPCPU_ID_PTR(_i, n), sizeof(*DPCPU_PTR(n)));	\
 	}								\
 } while(0)