From owner-freebsd-fs@freebsd.org Mon Jun 3 23:13:39 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FA2D15C0B3B for ; Mon, 3 Jun 2019 23:13:39 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660065.outbound.protection.outlook.com [40.107.66.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7F85374369; Mon, 3 Jun 2019 23:13:36 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM (52.132.93.160) by YQXPR01MB3189.CANPRD01.PROD.OUTLOOK.COM (52.132.90.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1943.22; Mon, 3 Jun 2019 23:13:35 +0000 Received: from YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a]) by YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM ([fe80::f9fe:559f:fdc:9e5a%3]) with mapi id 15.20.1943.018; Mon, 3 Jun 2019 23:13:35 +0000 From: Rick Macklem To: Alan Somers , Peter Eriksson CC: "freebsd-fs@freebsd.org" Subject: Re: RFC: should an incremental reload of exports for mountd be optional? Thread-Topic: RFC: should an incremental reload of exports for mountd be optional? Thread-Index: AQHVF/n5fA6XHqwN4UmNwJInW+ldyaaKg72AgAADv4CAAAwEhw== Date: Mon, 3 Jun 2019 23:13:35 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 510979e4-73bf-471c-7098-08d6e8791a7e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YQXPR01MB3189; x-ms-traffictypediagnostic: YQXPR01MB3189: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 0057EE387C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(366004)(396003)(376002)(136003)(189003)(199004)(51444003)(4326008)(33656002)(66476007)(66556008)(6246003)(74482002)(110136005)(5660300002)(64756008)(73956011)(76176011)(76116006)(66446008)(66946007)(229853002)(305945005)(99286004)(53546011)(8936002)(486006)(476003)(14454004)(6506007)(186003)(2906002)(71190400001)(71200400001)(11346002)(478600001)(102836004)(74316002)(52536014)(55016002)(86362001)(256004)(966005)(53936002)(81166006)(46003)(81156014)(25786009)(9686003)(6306002)(68736007)(786003)(7696005)(446003)(316002)(8676002)(6436002)(14444005); DIR:OUT; SFP:1101; SCL:1; SRVR:YQXPR01MB3189; H:YQXPR01MB3128.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: IpzZQgwgIowBlLDXQthCTORipzQCPfffKFztE8f9cA2ChIa9hkhrNJAoO+EOGwZUnR34w+4JmNV5v5I4Xh3dP8iIZLW8vrLFjQXdq9G7CrVvNT0ME5Fk4lE0y6SWzKi7skZy4SztZyJtOL+hHrwu6Owl8MU0mMrd2fJvvy2tbTkclfGeFa21o+HtznwoyEyEwOnOXSWVGlcJiREAbiQUM05IiewXcD1/hAcMIUPkwFtWoRTZyZJvbmgKPkB/wTka2r7U5poZMbHY6FDx1amm+S5xflPLRyhiiTqX6m7C2F+cKIbAE8SJpbFuIZK0o5bEP5IFpD6VKUEm2ZElvomKqO1pQCW8PIg3fJwupb2pDexr3LbprhOAhPWYREoqhi4oIhxzMXohjDvF/9/TnYhiZDdpPo2/rPKJ/SYfFi3yDu8= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 510979e4-73bf-471c-7098-08d6e8791a7e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2019 23:13:35.2075 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rmacklem@uoguelph.ca X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3189 X-Rspamd-Queue-Id: 7F85374369 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.65 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-3.30 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; FROM_HAS_DN(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; RCVD_IN_DNSWL_NONE(0.00)[65.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.02)[ipnet: 40.64.0.0/10(-2.84), asn: 8075(-2.18), country: US(-0.06)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; RCVD_TLS_LAST(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 23:13:39 -0000 Thanks everyone for your comments. I just committed the patch with the incremental reload of exports always enabled. If people run into problems, I can add some "backdoor" way to disable it, as suggested by asomers@. A restart of the daemon will always do a full reload to work around any reload failures. rick ________________________________________ From: Alan Somers Sent: Monday, June 3, 2019 6:28:51 PM To: Peter Eriksson Cc: Rick Macklem; freebsd-fs@freebsd.org Subject: Re: RFC: should an incremental reload of exports for mountd be opt= ional? I think that it should be always enabled. If the only reason not to is a fear of bugs in the new method, then the old method can be selected by some back-doorish workaround, like an environment variable. -Alan On Mon, Jun 3, 2019 at 4:16 PM Peter Eriksson wrote: > > My vote goes to: > > Enabled by default (with an option to disable it in case problems pop up)= . > > - Peter > > > > On 31 May 2019, at 23:50, Rick Macklem wrote: > > > > Hi, > > > > I have created a patch for PR#237860 that improves the time it takes to= reload > > the exports file(s) for an NFS file server from seconds->milliseconds b= y only doing > > system calls for the changes to the exports file(s). (Assumes each relo= ad includes > > changes to only a small fraction of the entries.) > > > > I made it a non-default option of "-I", but asomers@ asked why it neede= d to be > > optional. > > > > Basically, I made it optional because I felt the patch might still be b= uggy and not > > handle some case of an exports file change that I missed. > > > > However, I can see the argument of making it non-optional (or optional = but enabled > > by default) so that sysadmins don't need to add "-I" to avoid long peri= ods where the > > nfsd threads are suspended. > > If it is broken, the deamon would need to be restarted to do a full rel= oad, but that > > would also be the case if a sysadmin specified the "-I" option. > > > > So, the question is... "do you think this should be an option or just a= lways enabled?". > > > > Thanks , rick > > _______________________________________________ > > freebsd-fs@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"