From owner-cvs-ports@FreeBSD.ORG  Wed Feb 10 12:50:25 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0AD63106566B;
	Wed, 10 Feb 2010 12:50:25 +0000 (UTC)
	(envelope-from amdmi3@amdmi3.ru)
Received: from smtp.timeweb.ru (smtp.timeweb.ru [92.53.116.15])
	by mx1.freebsd.org (Postfix) with ESMTP id AF19F8FC1A;
	Wed, 10 Feb 2010 12:50:24 +0000 (UTC)
Received: from [213.148.20.85] (helo=hive.panopticon)
	by smtp.timeweb.ru with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <amdmi3@amdmi3.ru>)
	id 1NfC1F-0002NU-Vf; Wed, 10 Feb 2010 15:50:14 +0300
Received: from hades.panopticon (hades.panopticon [192.168.0.32])
	by hive.panopticon (Postfix) with ESMTP id 8BADAB860;
	Wed, 10 Feb 2010 15:50:22 +0300 (MSK)
Received: by hades.panopticon (Postfix, from userid 1000)
	id 6CD16B829; Wed, 10 Feb 2010 15:50:22 +0300 (MSK)
Date: Wed, 10 Feb 2010 15:50:22 +0300
From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Message-ID: <20100210125022.GD1538@hades.panopticon>
References: <201002092323.o19NNRvB090976@repoman.freebsd.org>
	<20100210092407.GA30717@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20100210092407.GA30717@FreeBSD.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile
 distinfo pkg-descr pkg-plist ports/audio/deadbeef/files
 patch-Makefile.am
 patch-Makefile.in patch-configure patch-configure.ac
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Feb 2010 12:50:25 -0000

* Alexey Dokuchaev (danfe@FreeBSD.org) wrote:

> Fully qualified person id (full name) should be used when available
> (Whom: line of Makefile header).

> COMMENT=	DeaDBeeF is an audio player for GNU/Linux systems with X11
> 		^^^^^^^^^^^^
> Mentioning program name in COMMENT is redundant; simple "An audio
> player..." would be enough.  "GNU/Linux" also looks strange on BSD system.
> "Unix[-like]" would be more appropriate.

Thanks, will resolve both with the next update.

> >   1.1       +13 -0     ports/audio/deadbeef/files/patch-Makefile.am (new)
> >   1.1       +21 -0     ports/audio/deadbeef/files/patch-Makefile.in (new)
> 
> Weird.  Can you explain why both of these patches are required, since .in
> is normally generated from .am (that is, patching .in is enough unless
> the port needs more of autotools magic than simple "./configure")?

Configure tends to rerun autotools when available sometimes, thus files
gets regenerated, so to be on a safe side, sources are patched as well.
Anyway, these patches will go away with the next update.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru