From owner-cvs-all@FreeBSD.ORG Mon Jul 31 19:43:49 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE7B716A4DD; Mon, 31 Jul 2006 19:43:49 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A75B43D70; Mon, 31 Jul 2006 19:43:23 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id k6VJhCTv004078 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 31 Jul 2006 23:43:12 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id k6VJhBRv004077; Mon, 31 Jul 2006 23:43:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 31 Jul 2006 23:43:11 +0400 From: Gleb Smirnoff To: Robert Watson Message-ID: <20060731194311.GV96644@FreeBSD.org> References: <200607200357.k6K3vwg2039627@repoman.freebsd.org> <20060731131502.GS96644@FreeBSD.org> <20060731144841.Y71432@fledge.watson.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20060731144841.Y71432@fledge.watson.org> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2006 19:43:50 -0000 On Mon, Jul 31, 2006 at 02:49:05PM +0100, Robert Watson wrote: R> On Mon, 31 Jul 2006, Gleb Smirnoff wrote: R> R> >On Thu, Jul 20, 2006 at 03:57:58AM +0000, Pyun YongHyeon wrote: R> >P> yongari 2006-07-20 03:57:58 UTC R> >P> R> >P> FreeBSD src repository R> >P> R> >P> Modified files: R> >P> sys/dev/em if_em.c R> >P> Log: R> >P> Honor IFF_DRV_OACTIVE in em_start_locked(). R> > R> >Isn't it better to shift this change to the em_start(), to avoid double R> >check of IFF_DRV_RUNNING? Or may be just merge em_start_locked() into the R> >em_start()? R> R> Isn't em_start_locked() called from quite a few different places, including R> the interrupt handler, etc, where the mutex is already held? It is, so the latter idea won't work. However, in all these places we can know the status of IFF_DRV_OACTIVE before calling the start routine. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE