From owner-freebsd-fs@FreeBSD.ORG Wed Aug 2 03:44:42 2006 Return-Path: X-Original-To: freebsd-fs@freebsd.org Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3135416A4E7 for ; Wed, 2 Aug 2006 03:44:42 +0000 (UTC) (envelope-from anderson@centtech.com) Received: from mh2.centtech.com (moat3.centtech.com [207.200.51.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id EEA0B43D68 for ; Wed, 2 Aug 2006 03:44:39 +0000 (GMT) (envelope-from anderson@centtech.com) Received: from [192.168.42.24] (andersonbox4.centtech.com [192.168.42.24]) by mh2.centtech.com (8.13.1/8.13.1) with ESMTP id k723icSW036088; Tue, 1 Aug 2006 22:44:38 -0500 (CDT) (envelope-from anderson@centtech.com) Message-ID: <44D01FB7.1020105@centtech.com> Date: Tue, 01 Aug 2006 22:44:55 -0500 From: Eric Anderson User-Agent: Thunderbird 1.5.0.4 (X11/20060612) MIME-Version: 1.0 To: Shane Adams References: <20060801205432.54066.qmail@web31812.mail.mud.yahoo.com> In-Reply-To: <20060801205432.54066.qmail@web31812.mail.mud.yahoo.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.87.1/1630/Tue Aug 1 10:38:56 2006 on mh2.centtech.com X-Virus-Status: Clean Cc: freebsd-fs@freebsd.org Subject: Re: Advice for hacking on ufs/ffs X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 03:44:42 -0000 On 08/01/06 15:54, Shane Adams wrote: > I think I found a bug in the ffs code, specifically in ffs_uninit and the uma_zcreates in ffs_vfsops.c > > You need to explicitly call zdestroy on uma_inode1, uma_ufs1 and uma_ufs2 in ffs_uninit otherwise if UFS/FFS (as a kernel module) is unloaded, you get a panic if you call sysctl -a after the kldunload. > > Now I'm new to freebsd, and on my system UFS/FFS is statically compiled, but I was screwing around and discovered this. Not sure how to report this or the patch (that fixed the problem on my system). Usually, people will post a patch somewhere for review, and/or submit a PR. Eric -- ------------------------------------------------------------------------ Eric Anderson Sr. Systems Administrator Centaur Technology Anything that works is better than anything that doesn't. ------------------------------------------------------------------------