From owner-cvs-src@FreeBSD.ORG Fri Jan 11 16:50:54 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E3FF616A41B; Fri, 11 Jan 2008 16:50:54 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B203813C43E; Fri, 11 Jan 2008 16:50:54 +0000 (UTC) (envelope-from kib@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m0BGosxk009602; Fri, 11 Jan 2008 16:50:54 GMT (envelope-from kib@repoman.freebsd.org) Received: (from kib@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m0BGorhh009597; Fri, 11 Jan 2008 16:50:53 GMT (envelope-from kib) Message-Id: <200801111650.m0BGorhh009597@repoman.freebsd.org> From: Konstantin Belousov Date: Fri, 11 Jan 2008 16:50:53 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/fdc fdc.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 16:50:55 -0000 kib 2008-01-11 16:50:53 UTC FreeBSD src repository Modified files: sys/dev/fdc fdc.c Log: The wakeup() line from the rev. 1.319 is wrong and reintroduces a panic race on module unload. The wakeup() is internal to kproc_exit/kthread_exit. The correct fix is to fix the msleep() in detach to sleep on fdc->fdc_thread instead of &fdc->fdc_thread. Noted and reviewed by: jhb Pointy hat to: kib MFC after: 1 week Revision Changes Path 1.320 +1 -2 src/sys/dev/fdc/fdc.c