From owner-freebsd-current@FreeBSD.ORG Tue Apr 6 10:40:55 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EB14716A4CE for ; Tue, 6 Apr 2004 10:40:55 -0700 (PDT) Received: from carver.gumbysoft.com (carver.gumbysoft.com [66.220.23.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEEB143D55 for ; Tue, 6 Apr 2004 10:40:55 -0700 (PDT) (envelope-from dwhite@gumbysoft.com) Received: by carver.gumbysoft.com (Postfix, from userid 1000) id 612A372DCA; Tue, 6 Apr 2004 10:39:36 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by carver.gumbysoft.com (Postfix) with ESMTP id 5CC7A72DBF; Tue, 6 Apr 2004 10:39:36 -0700 (PDT) Date: Tue, 6 Apr 2004 10:39:36 -0700 (PDT) From: Doug White To: Yuriy Tsibizov In-Reply-To: Message-ID: <20040406103912.R89264@carver.gumbysoft.com> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: freebsd-current@freebsd.org cc: Mathew Kanner Subject: RE: dev/sound/pcm/sound.h shadows INTR_MPSAFE declaration X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Apr 2004 17:40:56 -0000 On Tue, 6 Apr 2004, Yuriy Tsibizov wrote: > > > Today I've noticied that my driver is marked as Giant-locked: > > > > Is it actually MPSAFE? If so, feel free to mark it as such, > > although pcm > > isn't fully locked yet, so we take no responsibility for any damage > > caused :) > > Some sound drivers in -CURRENT allocate interrupts with INTR_MPSAFE. > The problem is that after including dev/sound/pcm/sound.h INTR_MPSAFE no longer equals to 512, but it is set to 0. And if sound driver interrupt was allocated as INTR_TYPE_AV|INTR_MPSAFE it will be marked only as INTR_TYPE_TTY. Ever think that might be intentional? :) I'd poke -multimedia to get the sound driver folks, though. -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org