From owner-freebsd-bugs@FreeBSD.ORG Tue May 31 16:40:03 2005 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A9A216A41F for ; Tue, 31 May 2005 16:40:03 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id C47F543D58 for ; Tue, 31 May 2005 16:40:02 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4VGe2IE049064 for ; Tue, 31 May 2005 16:40:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4VGe2oL049063; Tue, 31 May 2005 16:40:02 GMT (envelope-from gnats) Resent-Date: Tue, 31 May 2005 16:40:02 GMT Resent-Message-Id: <200505311640.j4VGe2oL049063@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Denis Grudkin Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B0C3C16A41C for ; Tue, 31 May 2005 16:39:50 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8EF0643D1F for ; Tue, 31 May 2005 16:39:50 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j4VGdols009209 for ; Tue, 31 May 2005 16:39:50 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j4VGdoBW009208; Tue, 31 May 2005 16:39:50 GMT (envelope-from nobody) Message-Id: <200505311639.j4VGdoBW009208@www.freebsd.org> Date: Tue, 31 May 2005 16:39:50 GMT From: Denis Grudkin To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: misc/81732: A typo in tftpd.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2005 16:40:03 -0000 >Number: 81732 >Category: misc >Synopsis: A typo in tftpd.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 31 16:40:02 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Denis Grudkin >Release: FreeBSD 5.4-STABLE >Organization: ROKSON network >Environment: FreeBSD 5.4-STABLE i386 >Description: tftpd server in FreeBSD 5.4-STABLE has an option -U to specify umask for newly created files. But then I tried to use this option I got segmentaion fault error. As I can see, the problem is in missed colon in getopt call in tftpd.c Revision of my tftpd.c is 1.34 >How-To-Repeat: Run tftpd server with -U option set. >Fix: Looks like all we need is to insert missing colon in tftpd.c $ diff -u /usr/src/libexec/tftpd/tftpd.c ./tftpd.c --- /usr/src/libexec/tftpd/tftpd.c Mon Aug 16 19:45:24 2004 +++ ./tftpd.c Tue May 31 20:07:42 2005 @@ -135,7 +135,7 @@ tzset(); /* syslog in localtime */ openlog("tftpd", LOG_PID | LOG_NDELAY, LOG_FTP); - while ((ch = getopt(argc, argv, "cClns:u:Uw")) != -1) { + while ((ch = getopt(argc, argv, "cClns:u:U:w")) != -1) { switch (ch) { case 'c': ipchroot = 1; >Release-Note: >Audit-Trail: >Unformatted: