From owner-dev-commits-src-all@freebsd.org  Wed May 19 05:54:20 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id DCCF9638248;
 Wed, 19 May 2021 05:54:20 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
Received: from annwfn.iks-jena.de (annwfn.iks-jena.de [IPv6:2001:4bd8::19])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FlMWc4MbJz4Tj2;
 Wed, 19 May 2021 05:54:20 +0000 (UTC)
 (envelope-from lutz@iks-jena.de)
X-SMTP-Sender: IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f
Received: from belenus.iks-jena.de (belenus.iks-jena.de
 [IPv6:2001:4bd8:0:666:248:54ff:fe12:ee3f])
 by annwfn.iks-jena.de (8.15.2/8.15.2) with ESMTPS id 14J5s7Av030977
 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT);
 Wed, 19 May 2021 07:54:07 +0200
X-MSA-Host: belenus.iks-jena.de
Received: (from lutz@localhost)
 by belenus.iks-jena.de (8.14.3/8.14.1/Submit) id 14J5s77T009919;
 Wed, 19 May 2021 07:54:07 +0200
Date: Wed, 19 May 2021 07:54:07 +0200
From: Lutz Donnerhacke <lutz@donnerhacke.de>
To: Joe Clarke <jclarke@marcuscom.com>, Zhenlei Huang <zlei.huang@gmail.com>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
 dev-commits-src-main@freebsd.org
Subject: Re: git: 3d846e48227e - main - Do not forward datagrams originated
 by link-local addresses
Message-ID: <20210519055407.GA9715@belenus.iks-jena.de>
References: <202105182101.14IL1Gki054229@gitrepo.freebsd.org>
 <D759CEBE-115A-404D-B12C-20A673923092@marcuscom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <D759CEBE-115A-404D-B12C-20A673923092@marcuscom.com>
X-message-flag: Please send plain text messages only. Thank you.
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Queue-Id: 4FlMWc4MbJz4Tj2
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00]; TAGGED_RCPT(0.00)[];
 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 May 2021 05:54:20 -0000

On Tue, May 18, 2021 at 07:51:38PM -0400, Joe Clarke wrote:
> Just out of curiosity, why remove the RFC reference from the comment?

May you please include the author of the change for such questions?

> > commit 3d846e48227e2e78c1e7b35145f57353ffda56ba
> > Author:     Zhenlei Huang <zlei.huang@gmail.com>
> > AuthorDate: 2021-05-18 20:51:37 +0000
> > Commit:     Lutz Donnerhacke <donner@FreeBSD.org>
> > CommitDate: 2021-05-18 20:59:46 +0000
> > 
> >    The current implement of ip_input() reject packets destined for
> >    169.254.0.0/16, but not those original from 169.254.0.0/16 link-local
> >    addresses.
> > 
> >    Fix to fully respect RFC 3927 section 2.7.
> > 
> >    PR:             255388
> >    Reviewed by:    donner, rgrimes, karels
> >    MFC after:      1 month
> >    Differential Revision:  https://reviews.freebsd.org/D29968

I did only commit this differential, but set a month for MFC, exactly to
have to opportunity to fix such mistakes.