Date: Wed, 19 Dec 2007 15:30:47 -0600 From: Paul Schmehl <pauls@utdallas.edu> To: freebsd-ports@freebsd.org Subject: Re: Optional patching Message-ID: <97B95C14B3E9CD8117362FF0@utd59514.utdallas.edu> In-Reply-To: <20071219205340.GD36016@atarininja.org> References: <4D1AAAB26DADCFB11343F6B3@utd59514.utdallas.edu> <47693FE9.20701@gahr.ch> <41364CD63DE952CCB8602A44@utd59514.utdallas.edu> <20071219191306.GC36016@atarininja.org> <20071219201316.1c305f7a@gumby.homeunix.com.> <20071219205340.GD36016@atarininja.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--On Wednesday, December 19, 2007 15:53:40 -0500 Wesley Shields
<wxs@atarininja.org> wrote:
> On Wed, Dec 19, 2007 at 08:13:16PM +0000, RW wrote:
>> On Wed, 19 Dec 2007 14:13:06 -0500
>> Wesley Shields <wxs@atarininja.org> wrote:
>>
>> > I don't think it matters really, but is probably a matter of personal
>> > preference. The only problem with using an option that I see is that
>> > if the user has no idea if (s)he is on a 64bit platform and turns the
>> > option off. It's for this reason I'd suggest using the .if ${ARCH}
>> > approach.
>>
>> I would have thought that the ".if ${ARCH}" method was the only
>> sensible way of doing it. Packages are built without any options set.
>
> They are built using the default OPTIONS in the Makefile - ie: those
> that are specified as "on". If what you say is true then one of my
> ports would not build properly - it requires at least one of a few
> options to be on.
>
> Another reason not to put it in as an OPTION is that if the option
> defaults to off the package will fail to build on 64bit platforms.
>
I completely agree. I just submitted a PR to update the port using .if ${ARCH}
==
Selecting the correct architechture should not be something the user has to do
when installing a port.
--
Paul Schmehl (pauls@utdallas.edu)
Senior Information Security Analyst
The University of Texas at Dallas
http://www.utdallas.edu/ir/security/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?97B95C14B3E9CD8117362FF0>