From nobody Sun May 5 17:57:07 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VXXLM5CVCz5KPwY; Sun, 05 May 2024 17:57:15 +0000 (UTC) (envelope-from olgeni@FreeBSD.org) Received: from hub.olgeni.com (hub.olgeni.com [31.171.246.156]) by mx1.freebsd.org (Postfix) with ESMTP id 4VXXLM36lzz4FH9; Sun, 5 May 2024 17:57:15 +0000 (UTC) (envelope-from olgeni@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.0.63] (93-45-74-52.ip101.fastwebnet.it [93.45.74.52]) by hub.olgeni.com (Postfix) with ESMTPSA id 435EBD7923; Sun, 05 May 2024 19:57:08 +0200 (CEST) Date: Sun, 5 May 2024 19:57:07 +0200 (CEST) From: Jimmy Olgeni To: Daniel Engberg cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 170431212955 - main - net/benthos: Add new port In-Reply-To: <4b7b52121e9ca725f281b28c0485c25b@mail.infomaniak.com> Message-ID: <61d10e7b-e5b3-a6bd-86bf-52b7f7ce81c5@FreeBSD.org> References: <202405051444.445EiQgm028494@gitrepo.freebsd.org> <4b7b52121e9ca725f281b28c0485c25b@mail.infomaniak.com> X-OpenPGP-KeyID: 0xFCDB3E82F778D8D7 X-OpenPGP-Fingerprint: EE37 B427 91C5 7707 EC54 064A FCDB 3E82 F778 D8D7 X-OpenPGP-URL: http://hub.olgeni.com/~olgeni/pgp/olgeni@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:50837, ipnet:31.171.244.0/22, country:CH] X-Rspamd-Queue-Id: 4VXXLM36lzz4FH9 Hi, On Sun, 5 May 2024, Daniel Engberg wrote: > On 2024-05-05T16:44:26.000+02:00, Jimmy Olgeni wrote: > > The branch main has been updated by olgeni: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=17043121295573db9777f6dd31364ee356$ > > > > commit 17043121295573db9777f6dd31364ee356e3154c > > Author: Jimmy Olgeni > > AuthorDate: 2024-05-05 14:08:37 +0000 > > Commit: Jimmy Olgeni > > CommitDate: 2024-05-05 14:43:31 +0000 > > > > net/benthos: Add new port > > > ... > > Please use ordering and variables as stated in Porters Handbook, > https://docs.freebsd.org/en/books/porters-handbook/book/#using-go I can drop the extra USE_GITHUB, GH_ACCOUNT, and GO_PKGNAME (works fine without) but is there anything else to fix? (also PORTVERSION could be DISTVERSION)