From owner-svn-ports-head@FreeBSD.ORG Wed Jul 30 20:14:20 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 660CCE4C; Wed, 30 Jul 2014 20:14:20 +0000 (UTC) Received: from idcmail-mo2no.shaw.ca (idcmail-mo2no.shaw.ca [64.59.134.9]) by mx1.freebsd.org (Postfix) with ESMTP id D1FA72FA5; Wed, 30 Jul 2014 20:14:19 +0000 (UTC) X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=PyywdG1hhzAAEaY8aZXFLtMUnlqk6chnja1kir+Tqrg= c=1 sm=1 a=Z5pHEwxCytgA:10 a=zzaxv6dU5mAA:10 a=QrugwKR0C_UA:10 a=wAGQQ9Az6v0A:10 a=BLceEmwcHowA:10 a=ICAaq7hcmGcA:10 a=kj9zAlcOel0A:10 a=IbtKDeXwb2+SRU442/pi3A==:17 a=sol3VE4AAAAA:8 a=6I5d2MoRAAAA:8 a=BWvPGDcYAAAA:8 a=aLfM1oOwXgKYOPSIIf0A:9 a=CjuIK1q_8ugA:10 a=V7tsTZBp22UA:10 a=SV7veod9ZcQA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO spqr.komquats.com) ([96.50.7.119]) by idcmail-mo2no.shaw.ca with ESMTP; 30 Jul 2014 14:14:18 -0600 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTP id E54F69E18; Wed, 30 Jul 2014 13:14:17 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.14.9/8.14.9) with ESMTP id s6UKEHpB007300; Wed, 30 Jul 2014 13:14:17 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.14.9/8.14.8/Submit) with ESMTP id s6UKEH45007297; Wed, 30 Jul 2014 13:14:17 -0700 (PDT) (envelope-from Cy.Schubert@komquats.com) Message-Id: <201407302014.s6UKEH45007297@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.komquats.com/ To: Baptiste Daroussin Subject: Re: svn commit: r363477 - head/sysutils/cfengine36 In-Reply-To: Message from Baptiste Daroussin of "Wed, 30 Jul 2014 18:43:35 +0200." <20140730164334.GL37672@ivaldir.etoilebsd.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 30 Jul 2014 13:14:16 -0700 Cc: Cy Schubert , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Cy Schubert X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2014 20:14:20 -0000 In message <20140730164334.GL37672@ivaldir.etoilebsd.net>, Baptiste Daroussin w rites: > Here is a new attempt: > https://people.freebsd.org/~bapt/cfengine36.diff > > This version keep your initial m4 patch and regenerate the configure. > Because I wasn't able to regenerate properly with the bsd.autotools.mk framew > ork > I simply run the right autoreconf command in pre-configure target. > As USES=libtool patch target happens after pre-configure then the uses works > properly > > Which leads to proper building of the lib (and the .so.3 being correctly > created) > > INSTALL_TARGET=install-strip makes sure your binary are stripped > > the options helpers are simply cosmetics > > USES=pgsql is the new proper way to hangle dependencies on pgsql :) I understand what these do. In addition to not including a file (strndup.m4) referenced by aclocal.m4, seems they also broke libtool.sh in the process. Your patch circumvents the issue, which is why we needed to regenerate the configure scripts. It works. This saves me a bit of work tonight. Thanks! Just committed with complete doc. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.