From owner-freebsd-current Wed Mar 12 7:49: 6 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AB03137B404 for ; Wed, 12 Mar 2003 07:49:04 -0800 (PST) Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212]) by mx1.FreeBSD.org (Postfix) with ESMTP id 28A8643FBF for ; Wed, 12 Mar 2003 07:49:01 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 974 invoked from network); 12 Mar 2003 15:49:03 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 12 Mar 2003 15:49:03 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id h2CFj2hT038533; Wed, 12 Mar 2003 10:45:03 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20030312141402.X61843@glass.pun-pun.prv> Date: Wed, 12 Mar 2003 10:49:14 -0500 (EST) From: John Baldwin To: Tod McQuillin Subject: RE: lock order reversal? current with tl ethernet Cc: freebsd-current@freebsd.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 12-Mar-2003 Tod McQuillin wrote: > > Running -current from March 11 on a dual cpu compaq 5100, there are some > warnings in the dmesg about the tl ethernet interface. > > Here are the warnings: > > malloc() of "128" with the following non-sleepablelocks held: > exclusive sleep mutex tl0 (network driver) r = 0 (0xc4017aa8) locked @ > /usr/src/5-current/src/sys/pci/if_tl.c:1146 It's holding the lock across bus_setup_intr(). You can try the following patch: Index: if_tl.c =================================================================== RCS file: /usr/cvs/src/sys/pci/if_tl.c,v retrieving revision 1.74 diff -u -r1.74 if_tl.c --- if_tl.c 19 Feb 2003 05:47:41 -0000 1.74 +++ if_tl.c 12 Mar 2003 15:20:47 -0000 @@ -1138,12 +1138,11 @@ if (t->tl_name == NULL) { device_printf(dev, "unknown device!?\n"); - goto fail; device_printf(dev, "unknown device!?\n"); - goto fail; RCS file: /usr/cvs/src/sys/pci/if_tl.c,v retrieving revision 1.74 diff -u -r1.74 if_tl.c --- if_tl.c 19 Feb 2003 05:47:41 -0000 1.74 +++ if_tl.c 12 Mar 2003 15:20:47 -0000 @@ -1138,12 +1138,11 @@ if (t->tl_name == NULL) { device_printf(dev, "unknown device!?\n"); - goto fail; + return (ENXIO); } mtx_init(&sc->tl_mtx, device_get_nameunit(dev), MTX_NETWORK_LOCK, MTX_DEF | MTX_RECURSE); - TL_LOCK(sc); /* * Map control/status registers. @@ -1348,12 +1347,12 @@ /* * Call MI attach routine. */ -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message