From owner-freebsd-arch@FreeBSD.ORG  Wed Jul 30 06:49:58 2008
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7F7941065670;
	Wed, 30 Jul 2008 06:49:58 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A9558FC0A;
	Wed, 30 Jul 2008 06:49:58 +0000 (UTC) (envelope-from des@des.no)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 710E02092;
	Wed, 30 Jul 2008 08:49:56 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: arch@freebsd.org
References: <20080729.161303.709402272.imp@bsdimp.com>
Date: Wed, 30 Jul 2008 08:49:55 +0200
In-Reply-To: <20080729.161303.709402272.imp@bsdimp.com> (M. Warner Losh's
	message of "Tue\, 29 Jul 2008 16\:13\:03 -0600 \(MDT\)")
Message-ID: <86r69buar0.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: kan@freebsd.org, pjd@freebsd.org
Subject: Re: Need a code review
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2008 06:49:58 -0000

"M. Warner Losh" <imp@bsdimp.com> writes:
> http://people.freebsd.org/~gonzo/mips2/libpam.diff

This won't work.  Your patch unconditionally sets NO_STATIC_MODULES
which will result in a non-functional libpam.a (the modules will be
built into the library, but without any of the glue that allows the
library to find them) not just on mips, but on all other platforms.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no