Date: Sat, 6 Jan 2001 09:30:03 -0800 (PST) From: Soren Schmidt <sos@freebsd.dk> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/24109: patch for making the atapi-cd drive waits for media Message-ID: <200101061730.f06HU3F17578@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/24109; it has been noted by GNATS.
From: Soren Schmidt <sos@freebsd.dk>
To: alexandre12@mageos.com
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: kern/24109: patch for making the atapi-cd drive waits for media
Date: Sat, 6 Jan 2001 18:25:46 +0100 (CET)
It seems alexandre12@mageos.com wrote:
> --- dev/ata/atapi-cd.c.orig Sat Jan 6 16:41:54 2001
> +++ dev/ata/atapi-cd.c Sat Jan 6 16:44:39 2001
> @@ -490,6 +490,12 @@
> struct acd_softc *cdp;
> int track = (dev->si_udev & 0x00ff0000) >> 16;
>
> + /*
> + * Close the CDROM door and waits for the media to be ready (patch by <alexandre12@mageos.com>)
> + */
> +
> + acdioctl(dev, CDIOCCLOSE,0,flags, p);
> +
> if (track) {
> dev_t dev1 = makedev(major(dev), (dev->si_udev & 0xff0000ff));
This will do the same, but is much cleaner:
--- atapi-cd.c 2000/10/25 06:43:02 1.48.2.6
+++ atapi-cd.c 2001/01/06 17:24:39
@@ -490,6 +490,8 @@
struct acd_softc *cdp;
int track = (dev->si_udev & 0x00ff0000) >> 16;
+ acd_eject(cdp, 1);
+
if (track) {
dev_t dev1 = makedev(major(dev), (dev->si_udev & 0xff0000ff));
But I'm not sure I want this to happen....
-Søren
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200101061730.f06HU3F17578>