From owner-freebsd-current@FreeBSD.ORG Tue Sep 17 22:53:18 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 22F0DABE; Tue, 17 Sep 2013 22:53:18 +0000 (UTC) (envelope-from prvs=19726a1fa9=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8C1142B03; Tue, 17 Sep 2013 22:53:17 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50006013617.msg; Tue, 17 Sep 2013 23:53:08 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Tue, 17 Sep 2013 23:53:08 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=19726a1fa9=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: <4AA28730F331444AB13108ABF0CD68B7@multiplay.co.uk> From: "Steven Hartland" To: "Justin T. Gibbs" References: <1379069539.824504225.3b9xwugp@fmst-6.ukr.net><74C1D072-77BB-4D6C-B78F-C8D2731FA0CF@sarenet.es><1379333192.127359970.ma5jnbc5@fmst-6.ukr.net> <1379334340.567465877.0b1lli6r@fmst-6.ukr.net> <8365CE736DC749DF95D0030A725211F6@multiplay.co.uk> <02549AD9-C456-4E17-927C-B4BCC97F8CC8@freebsd.org> Subject: Re: ZFS secondarycache on SSD problem on r255173 Date: Tue, 17 Sep 2013 23:53:12 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_01FD_01CEB401.11C4CC00" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: freebsd-current@freebsd.org, Borja Marcos , Dmitriy Makarov X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Sep 2013 22:53:18 -0000 This is a multi-part message in MIME format. ------=_NextPart_000_01FD_01CEB401.11C4CC00 Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original Content-Transfer-Encoding: 7bit ----- Original Message ----- From: "Justin T. Gibbs" > Sorry for being slow to chime in on this thread. I live in Boulder, CO and we've had a bit of rain. :-) Hope all is well your side, everyone safe and sound if may be little wetter than usual. > As Steven pointed out, the warning is benign, but does show that the code I committed to > -current is not optimizing the allocation size for L2ARC devices. The fix for this is to find > the best place during pool creation/load/import to call vdev_ashift_optimize() on L2ARC > devices. I will look into this tomorrow, but feel free to suggest a good spot if you look at it > before I can. The attached patch fixes this for me, not sure if its ideal place for it and consideration may be needed in combination with persistent l2arc. Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk. ------=_NextPart_000_01FD_01CEB401.11C4CC00 Content-Type: application/octet-stream; name="zfs-l2arc-ashift.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="zfs-l2arc-ashift.patch" Index: sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= --- sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c (revision = 255531)=0A= +++ sys/cddl/contrib/opensolaris/uts/common/fs/zfs/arc.c (working copy)=0A= @@ -5387,6 +5387,8 @@ l2arc_add_vdev(spa_t *spa, vdev_t *vd)=0A= =0A= ASSERT(!l2arc_vdev_present(vd));=0A= =0A= + vdev_ashift_optimize(vd);=0A= +=0A= /*=0A= * Create a new l2arc device entry.=0A= */=0A= ------=_NextPart_000_01FD_01CEB401.11C4CC00--