From owner-freebsd-stable Wed Jul 3 10:39: 6 2002 Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E081537B400; Wed, 3 Jul 2002 10:39:01 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4297343E3B; Wed, 3 Jul 2002 10:39:01 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.5/8.12.2) with ESMTP id g63HcoXu009087; Wed, 3 Jul 2002 10:38:50 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.5/8.12.5/Submit) id g63HcopN009086; Wed, 3 Jul 2002 10:38:50 -0700 (PDT) Date: Wed, 3 Jul 2002 10:38:50 -0700 From: "David O'Brien" To: Garance A Drosihn Cc: Dag-Erling Smorgrav , Adrian Penisoara , freebsd-stable@FreeBSD.ORG, bde@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: __FBSDID breaks buildworld upgrading Message-ID: <20020703103850.A9003@dragon.nuxi.com> Reply-To: obrien@FreeBSD.ORG References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from drosih@rpi.edu on Wed, Jul 03, 2002 at 01:12:45PM -0400 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jul 03, 2002 at 01:12:45PM -0400, Garance A Drosihn wrote: > #include > #ifdef __FBSDID > __FBSDID("$FreeBSD$"); > #endif Uh, ugly and totally not needed on my FreeBSD system. Don't ulgify things for some hypotheical need. I proposed that we move all this type of stuff out of to /usr/include/scmid.h. This would make it easy for those using the code outside of FreeBSD to create a scmid.h file with the needed bits. > which in turn would get in trouble on some other platforms, if > they don't have , or if they DO have it, and they > do not define __FBSDID, and you're one of those strange people > who would like to see RCS-id's in your object files even when > you are not compiling under the latest versions of freebsd. I > suppose we could take it even further and try: > > #include > #ifdef __FBSDID > __FBSDID("$FreeBSD$"); > #else > static const char rcsid[] = > "$FreeBSD$"; > #endif Ugly, ugly, ugly, ugly. > #if !defined(lint) && !defined(NO__RCSID) > static const char rcsid[] = > "$FreeBSD$"; > #endif Nope, this puts the ID in the data section vs. a seperate section, which can be stripped. > Now, I imagine we can solve this immediate buildworld problem by > adding some steps to buildworld, or "do things in the right order", > but again why should we bother? Whatever we do for buildworld will > not help if someone just wants to pick up a single source file from > 4.6-stable and compile it on an "ancient" OS such as 4.4-release. > We talk about providing support for older releases of FreeBSD, Not in this way -- where has any developer claimed you can take X.Y code and compile it on X.(Y-2)? > I really do not mean this as an insult to anyone, but I think we > are so fascinated with the few real advantages of __FBSDID (such > as getting the RCS-ids into a separate ELF section) that we are > sinking far too much effort into trying to make it work. What effort? My RELENG_4 systems build world just fine, as do my -CURRENT ones [and when they don't it isn't because of this]. > Are the benefits really worth all that effort? Yes. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message