From owner-freebsd-bugs@FreeBSD.ORG  Tue Nov 16 14:00:49 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CE7E516A4CE; Tue, 16 Nov 2004 14:00:49 +0000 (GMT)
Received: from woozle.rinet.ru (woozle.rinet.ru [195.54.192.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 876DB43D45; Tue, 16 Nov 2004 14:00:48 +0000 (GMT)
	(envelope-from marck@rinet.ru)
Received: from localhost (localhost [127.0.0.1])
	by woozle.rinet.ru (8.13.1/8.13.1) with ESMTP id iAGE0lKG062182;
	Tue, 16 Nov 2004 17:00:47 +0300 (MSK)
	(envelope-from marck@rinet.ru)
Date: Tue, 16 Nov 2004 17:00:47 +0300 (MSK)
From: Dmitry Morozovsky <marck@rinet.ru>
To: Giorgos Keramidas <keramida@freebsd.org>
In-Reply-To: <200411161200.iAGC0mir091454@freefall.freebsd.org>
Message-ID: <20041116165859.C57439@woozle.rinet.ru>
References: <200411161200.iAGC0mir091454@freefall.freebsd.org>
X-NCC-RegID: ru.rinet
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-bugs@freebsd.org
Subject: Re: misc/73992: periodic security not showing faily firewall diffs
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Nov 2004 14:00:50 -0000

On Tue, 16 Nov 2004, Giorgos Keramidas wrote:

GK>  Wouldn't a better fix be to change the default filter in check_diff()
GK>  to make sure the correct pattern is used?  I'm thinking of something
GK>  like this:
GK>  
GK>  : Index: security.functions
GK>  : ===================================================================
GK>  : RCS file: /home/ncvs/src/etc/periodic/security/security.functions,v
GK>  : retrieving revision 1.4
GK>  : diff -u -u -r1.4 security.functions
GK>  : --- security.functions   23 Sep 2004 02:00:51 -0000      1.4
GK>  : +++ security.functions   16 Nov 2004 11:55:03 -0000
GK>  : @@ -44,6 +44,9 @@
GK>  :    if [ "$1" = "new_only" ]; then
GK>  :      shift
GK>  :      filter="grep '^>'"
GK>  : +    case $daily_status_security_diff_flags in
GK>  : +      *-u*|*-c*) filter="grep '^+[^+]'" ;;
GK>  : +    esac
GK>  :    else
GK>  :      filter="cat"
GK>  :    fi

It will miss changes in context diffs (they are marked by '!'), won't it?

Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------