From owner-freebsd-hackers Wed Oct 8 13:43:02 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id NAA13510 for hackers-outgoing; Wed, 8 Oct 1997 13:43:02 -0700 (PDT) (envelope-from owner-freebsd-hackers) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (8.8.7/8.8.7) with SMTP id NAA13502 for ; Wed, 8 Oct 1997 13:42:58 -0700 (PDT) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id WAA03716; Wed, 8 Oct 1997 22:42:56 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.8.7/8.8.5) id VAA15854; Wed, 8 Oct 1997 21:50:18 +0200 (MET DST) Message-ID: <19971008215018.SO62644@uriah.heep.sax.de> Date: Wed, 8 Oct 1997 21:50:18 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: hackers@FreeBSD.ORG Cc: mrcpu@cdsnet.net (Jaye Mathisen) Subject: Re: A TCP problem, plus solution! (3.0-current) References: X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: ; from Jaye Mathisen on Oct 8, 1997 10:44:28 -0700 Sender: owner-freebsd-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Jaye Mathisen wrote: > I traced it to a sysctl I had in /etc/rc.local that bumped the tcp > recvspace to 65536. > > Resetting it to the default clears the problem up. You are not running -current. ;-) RCS file: /home/cvs/src/sys/netinet/tcp_output.c,v ... revision 1.27 date: 1997/10/07 21:10:06; author: fenner; state: Exp; lines: +3 -3 Don't allow the window to be increased beyond what is possible to represent in the TCP header. The old code did effectively: win = min(win, MAX_ALLOWED); win = max(win, what_i_think_i_advertised_last_time); so if what_i_think_i_advertised_last_time is bigger than can be represented in the header (e.g. large buffers and no window scaling) then we stuff a too-big number into a short. This fix reverses the order of the comparisons. PR: kern/4712 -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)