From owner-freebsd-bugs@freebsd.org Sat Jun 15 14:55:13 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6C7015C9332 for ; Sat, 15 Jun 2019 14:55:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 269D077C93 for ; Sat, 15 Jun 2019 14:55:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D63B815C9331; Sat, 15 Jun 2019 14:55:12 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9792E15C9330 for ; Sat, 15 Jun 2019 14:55:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3301977C8F for ; Sat, 15 Jun 2019 14:55:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 6B01ACC20 for ; Sat, 15 Jun 2019 14:55:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x5FEtBai027812 for ; Sat, 15 Jun 2019 14:55:11 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x5FEtBIU027811 for bugs@FreeBSD.org; Sat, 15 Jun 2019 14:55:11 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 238580] [PATCH] respect defines from 'sys/netinet/ip_carp.h' Date: Sat, 15 Jun 2019 14:55:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: egypcio@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2019 14:55:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238580 Bug ID: 238580 Summary: [PATCH] respect defines from 'sys/netinet/ip_carp.h' Product: Base System Version: CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: bugs@FreeBSD.org Reporter: egypcio@FreeBSD.org Created attachment 205076 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D205076&action= =3Dedit D20638.diff based on information from man pages like carp(4) and ifconfig(8), some inconstant values popped out while I troubleshooted a HA setup using CARP. - advskew was able to be changed to values higher than CARP_MAXSKEW; - CARP advertisements collected via tcpdump were still using (respecting)= its limit; changing values on net.inet.carp.demotion does not increase advskew above t= he limit (expected, I think). root@fw1-lab:~ # uname -UKvm FreeBSD 13.0-CURRENT r348978 GENERIC amd64 1300031 1300031 root@fw1-lab:~ # ifconfig vlan3131 vhid 10 advskew 254 root@fw1-lab:~ # echo $? 0 root@fw1-lab:~ # ifconfig vlan3131 | grep carp carp: MASTER vhid 10 advbase 1 advskew 254 root@fw1-lab:~ # tcpdump -c 1 -n -v -i vlan3131 carp -T carp tcpdump: listening on vlan3131, link-type EN10MB (Ethernet), capture size 262144 bytes 15:56:59.299379 IP (tos 0xe0, ttl 255, id 0, offset 0, flags [DF], proto VR= RP (112), length 56) 172.31.31.1 > 224.0.0.18: carp 172.31.31.1 > 224.0.0.18: CARPv2-adverti= se 36: vhid=3D10 advbase=3D1 advskew=3D240 authlen=3D7 counter=3D8688083474654= 986394 1 packet captured 1 packet received by filter 0 packets dropped by kernel --=20 You are receiving this mail because: You are the assignee for the bug.=