From owner-freebsd-net@FreeBSD.ORG Fri Jan 6 16:33:43 2012 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 574531065670; Fri, 6 Jan 2012 16:33:43 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id D212F8FC0A; Fri, 6 Jan 2012 16:33:42 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id C99B325D386E; Fri, 6 Jan 2012 16:33:41 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 0A830BD89B6; Fri, 6 Jan 2012 16:33:41 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 1OYQy+-FByEB; Fri, 6 Jan 2012 16:33:39 +0000 (UTC) Received: from orange-en1.sbone.de (orange-en1.sbone.de [IPv6:fde9:577b:c1a9:31:cabc:c8ff:fecf:e8e3]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 655DABD89B4; Fri, 6 Jan 2012 16:33:39 +0000 (UTC) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: "Bjoern A. Zeeb" In-Reply-To: <20120106153500.GA78077@sandvine.com> Date: Fri, 6 Jan 2012 16:33:38 +0000 Content-Transfer-Encoding: 7bit Message-Id: <1558626A-39B9-4533-9057-737FBC37898A@lists.zabbadoz.net> References: <20120104.040611.1847309275485655567.hrs@allbsd.org> <4F036A7F.9030906@FreeBSD.org> <52D4B9DF-4BC3-4AF7-BCE0-A88E18F25650@gmail.com> <20120104.144214.74742226.sthaug@nethelp.no> <20120106153500.GA78077@sandvine.com> To: Ed Maste X-Mailer: Apple Mail (2.1084) Cc: freebsd-net@freebsd.org, J David Subject: Re: openbgpds not talking each other since 8.2-STABLE upgrade X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jan 2012 16:33:43 -0000 On 6. Jan 2012, at 15:35 , Ed Maste wrote: > Yes, your testing clearly demonstrates some kernel issues here. I'll > see if I can find someone to investigate (or can help guide further > debugging). > > Thanks again for the effort here so far. I am still having trouble with the table (as I had with the original mail, which was just too long - as is the table). The bottom lines are: 0) Drop all test cases with the sysctl turned off (they should dtrt also w/o the sysctl). It should be a SADB policy && socket option decision (depending on direction). 1) there is a problem in _syncache_add leading to the wrong behaviour in situations in respond. 2) there is another problem I haven't looked at where to say it is, basically related to the way we decide to treat (0) (but also in the other direction) 3) there is a problem of not properly checking an error case in tcp_subr.c at one point but would be void if (0/2) was done right in both directions. If you can wait till early next week I might have a patch that cleans parts of this up in general and we can go from there? /bz -- Bjoern A. Zeeb You have to have visions! It does not matter how good you are. It matters what good you do!